fix(table): update to tablewriter v1 apis #3460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandt Keller <[email protected]>
Signed-off-by: Brandt Keller <[email protected]>
brandtkeller
commented
Jul 15, 2025
| @@ -100,28 +102,43 @@ func (t *table) addRow(r Row) { | |||
| t.Rows = append(t.Rows, r) | |||
| } | |||
|
|
|||
| func (t *table) dump(w io.Writer) { | |||
| func (t *table) dump(w io.Writer) error { | |||
There was a problem hiding this comment.
not positive if this is an interface definition somewhere - if so would appreciate feedback for expectations on linting. (IE should we flag as //nolint:errcheckl?)
There was a problem hiding this comment.
@brandtkeller Thank you for looking into this! If memory serves.... dump was just used for debugging. So we could either omit the error aka _ = xxx at the call site or log it.
derailed
approved these changes
Jul 16, 2025
| @@ -100,28 +102,43 @@ func (t *table) addRow(r Row) { | |||
| t.Rows = append(t.Rows, r) | |||
| } | |||
|
|
|||
| func (t *table) dump(w io.Writer) { | |||
| func (t *table) dump(w io.Writer) error { | |||
There was a problem hiding this comment.
@brandtkeller Thank you for looking into this! If memory serves.... dump was just used for debugging. So we could either omit the error aka _ = xxx at the call site or log it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The update of grype/syft have a dependency on the tablewriter PR - which moves from
v0.0.5tov1.0.8and includes breaking changes. As a maintainer of a project that uses k9s - I wanted to help overcome the transition as I have done it on a few other projects now and the migration is quite simple.Context
Fixes #3459
This PR provides an update to tablewriter -> Parity in the previous use the tablewriter dependency -> updates to syft/grype required to compile.
Assoicated PRs
Dependabot should automatically close the following PR's as complete following the merge of this PR.