castSegments: Remove unnecessary handling of nested array and non-array cases that don't actually occur

Author: ericyhwang

src/util.ts

@@ -39,22 +39,15 @@ class AsyncGroup {
   }
 }
 
-function castSegment(segment: string): string | number {
+function castSegment(segment: string | number): string | number {
   return (typeof segment === 'string' && isArrayIndex(segment))
     ? +segment // sneaky op to convert numeric string to number
     : segment;
 }
 
-export function castSegments(segments: Readonly<string | string[]>) {
-  if (typeof segments === 'string') {
-    return castSegment(segments);
-  }
+export function castSegments(segments: Readonly<Array<string | number>>) {
   // Cast number path segments from strings to numbers
-  return segments.map(segment =>
-    Array.isArray(segment)
-      ? castSegments(segment)
-      : castSegment(segment)
-  );
+  return segments.map(segment => castSegment(segment));
 }
 
 export function contains(segments, testSegments) {

test/util/util.js

@@ -89,10 +89,5 @@ describe('util', function() {
       expect(actual).to.eql(['foo', 3, 3]);
       expect(actual).to.not.equal(segments); // args not mutated
     });
-
-    it('handles plain strings', () => {
-      expect(util.castSegments('foo.bar')).to.eql('foo.bar');
-      expect(util.castSegments('6')).to.eql(6);
-    });
   });
 });