Skip to content

Commit a4c6e9b

Browse files
committed
don't do needless filtering in the cached_exporter get_metrics
filtering is done by the export call on the exporter Signed-off-by: Zen <[email protected]>
1 parent e7ab560 commit a4c6e9b

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/prometheus_exporter/cached_exporter.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,6 @@ def cache_age(self) -> int:
6161
async def get_metrics(self, label_filter=None) -> list:
6262
"""Get metrics from the exporter, respecting label filters and caching the result."""
6363
label_filter = label_filter or {}
64-
for key, value in label_filter.items():
65-
if key not in self.labels and self.labels[key] != value:
66-
self.logger.debug("Label filter check failed: %s != %s", self.labels, label_filter)
67-
return []
6864

6965
if not hasattr(self, "_cached_metrics") or self.cache_age >= self.cache_life:
7066
if new_metrics := await super().get_metrics(label_filter=label_filter):

0 commit comments

Comments
 (0)