Skip to content

Commit 913b44d

Browse files
authored
Merge pull request #334 from desultory/dev
add warning for when lsmod is used to detect many modules
2 parents 2713866 + 8149d59 commit 913b44d

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/ugrd/kmod/kmod.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,12 @@ def _autodetect_modules_lsmod(self) -> None:
143143
)
144144

145145
with open("/proc/modules", "r") as f:
146-
for module in f.readlines():
147-
self["_kmod_auto"] = module.split()[0]
146+
modules = [line.split()[0] for line in f.readlines()]
147+
148+
if len(modules) > 25:
149+
self.logger.warning(f"[{len(modules)}] More than 25 kernel modules were autodetected from the running kernel. If lsmod detection is required for your use case, please file a bug report so more appropriate detection methods can be implemented.")
150+
for module in modules:
151+
self["_kmod_auto"] = module.split()[0]
148152

149153

150154
@unset("no_kmod", "no_kmod is enabled, skipping.", log_level=30)

0 commit comments

Comments
 (0)