Skip to content

Commit d9f2aba

Browse files
committed
remove decorator
Signed-off-by: Zen <[email protected]>
1 parent f833c4e commit d9f2aba

File tree

1 file changed

+7
-14
lines changed

1 file changed

+7
-14
lines changed

src/ugrd/kmod/kmod.py

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,6 @@ def _normalize_kmod_name(module: Union[str, list]) -> str:
1818
return module.replace('-', '_')
1919

2020

21-
# Decorator to normalize the first argument of a function, as a kmod name
22-
def normalized_module(func):
23-
def wrapper(self, module: Union[str, list], *args, **kwargs):
24-
return func(self, _normalize_kmod_name(module), *args, **kwargs)
25-
return wrapper
26-
27-
2821
class DependencyResolutionError(Exception):
2922
pass
3023

@@ -37,9 +30,9 @@ class IgnoredModuleError(Exception):
3730
pass
3831

3932

40-
@normalized_module
4133
def _process_kernel_modules_multi(self, module: str) -> None:
4234
""" Adds kernel modules to self['kernel_modules']. """
35+
module = _normalize_kmod_name(module)
4336
if module in self['kmod_ignore']:
4437
self.logger.debug("[%s] Module is in the ignore list." % module)
4538
self['_kmod_removed'] = module
@@ -49,19 +42,19 @@ def _process_kernel_modules_multi(self, module: str) -> None:
4942
self['kernel_modules'].append(module)
5043

5144

52-
@normalized_module
5345
def _process_kmod_init_multi(self, module: str) -> None:
5446
""" Adds init modules to self['kernel_modules']. """
47+
module = _normalize_kmod_name(module)
5548
if module in self['kmod_ignore']:
5649
raise IgnoredModuleError("kmod_init module is in the ignore list: %s" % module)
5750
self['kmod_init'].append(module)
5851
self.logger.debug("Adding kmod_init module to kernel_modules: %s", module)
5952
self['kernel_modules'] = module
6053

6154

62-
@normalized_module
6355
def _process__kmod_auto_multi(self, module: str) -> None:
6456
""" Adds autodetected modules to self['kernel_modules']. """
57+
module = _normalize_kmod_name(module)
6558
if module in self['kmod_ignore']:
6659
self.logger.debug("Autodetected module is in the ignore list: %s" % module)
6760
self['_kmod_removed'] = module
@@ -70,12 +63,12 @@ def _process__kmod_auto_multi(self, module: str) -> None:
7063
self['_kmod_auto'].append(module)
7164

7265

73-
@normalized_module
7466
def _get_kmod_info(self, module: str):
7567
"""
7668
Runs modinfo on a kernel module, parses the output and stored the results in self['_kmod_modinfo'].
7769
!!! Should be run after metadata is processed so the kver is set properly !!!
7870
"""
71+
module = _normalize_kmod_name(module)
7972
if module in self['_kmod_modinfo']:
8073
return self.logger.debug("[%s] Module info already exists." % module)
8174
args = ['modinfo', module, '--set-version', self['kernel_version']]
@@ -201,9 +194,9 @@ def regen_kmod_metadata(self) -> None:
201194
self._run(['depmod', '--basedir', build_dir, self['kernel_version']])
202195

203196

204-
@normalized_module
205197
def _add_kmod_firmware(self, kmod: str) -> None:
206198
""" Adds firmware files for the specified kernel module to the initramfs. """
199+
kmod = _normalize_kmod_name(kmod)
207200
if kmod not in self['_kmod_modinfo']:
208201
raise DependencyResolutionError("Kernel module info does not exist: %s" % kmod)
209202

@@ -217,9 +210,9 @@ def _add_kmod_firmware(self, kmod: str) -> None:
217210
_add_firmware_dep(self, kmod, firmware)
218211

219212

220-
@normalized_module
221213
def _add_firmware_dep(self, kmod: str, firmware: str) -> None:
222214
""" Adds a kernel module firmware file to the initramfs dependencies. """
215+
kmod = _normalize_kmod_name(kmod)
223216
firmware_path = Path('/lib/firmware') / firmware
224217
if not firmware_path.exists():
225218
if firmware_path.with_suffix(firmware_path.suffix + '.xz').exists():
@@ -234,9 +227,9 @@ def _add_firmware_dep(self, kmod: str, firmware: str) -> None:
234227
self['dependencies'] = firmware_path
235228

236229

237-
@normalized_module
238230
def _process_kmod_dependencies(self, kmod: str) -> None:
239231
""" Processes a kernel module's dependencies. """
232+
kmod = _normalize_kmod_name(kmod)
240233
_get_kmod_info(self, kmod)
241234
# Add dependencies of the module
242235
dependencies = []

0 commit comments

Comments
 (0)