Skip to content

Commit e7b0ea4

Browse files
committed
fix error throwing
Signed-off-by: Zen <[email protected]>
1 parent 15ac9eb commit e7b0ea4

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

ugrd/kmod/kmod.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def _get_kmod_info(self, module: str):
106106
raise DependencyResolutionError("[%s] Failed to run modinfo command: %s" % (module, ' '.join(args))) from e
107107

108108
module_info = {}
109-
for line in cmd.stdout.decode().strip().split('\n'):
109+
for line in cmd.stdout.decode().split('\n'):
110110
line = line.strip()
111111
if line.startswith('filename:'):
112112
module_info['filename'] = line.split()[1]
@@ -122,9 +122,9 @@ def _get_kmod_info(self, module: str):
122122
if 'firmware' not in module_info:
123123
module_info['firmware'] = []
124124
module_info['firmware'] += line.split()[1:]
125-
else:
126-
self.logger.warning("[%s] Failed to parse modinfo output: %s" % (module, cmd.stdout.decode().strip()))
127-
raise DependencyResolutionError("Failed to get modinfo for: %s" % module)
125+
126+
if not module_info:
127+
raise DependencyResolutionError("[%s] Failed to process modinfo output: %s" % (module, cmd.stdout.decode()))
128128

129129
self.logger.debug("[%s] Module info: %s" % (module, module_info))
130130
self['_kmod_modinfo'][module] = module_info

0 commit comments

Comments
 (0)