amdgpu firmware causes errors when kmod_pull_firmware set to true #296
Description
There seems to be a couple of errors that the amdgpu firmware causes (had to set kmod_pull_firmware to false).
- The first is it somehow causes an index error on https://github.com/desultory/pycpio/blob/60facf579efb975235838d0fa07f0c5b19b15fa1/src/pycpio/cpio/archive.py#L58, I hacked in a check for
self.inodes[entry.header.ino]before attempting to access the first element of the list which seemed to resolve that problem, but revealed another. - The second issue is a hash collision between the navi10_ta.bin and navi14 _ta.bin. It appears all 3 first generation navi _ta.bin files are the same (or so says sha256sum). I'm not sure what the best answer for this is, maybe it's just to not include the firmware. The ultimate solution may be that users just need to "know better" and use the savedconfig feature of
linux-firmwareto exclude the firmware blobs they do not need (though that is a Gentoo-centric solution), or accept that some firmware binaries will be duplicates and find a way to handle duplicate hashes (maybe pretend the duplicate files are symlinks since it looks like those are already handled).