module ugrd.base.plymouth: lddtree: warning: /usr/sbin/plymouth-set-default-theme: Magic number does not match

[sinatosk]

I'm using ugrd 2.0.2 and plymouth 22.02.122-r4 on Gentoo, both stable packages

With modules set at

modules = [
   "ugrd.fs.resume",
   "ugrd.base.plymouth",
]

in /etc/ugrd/config.toml

after "make install", I see this warning/error

WARNING  | Unable to calculate dependencies for: plymouth-set-default-theme
Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.13/ugrd", line 8, in <module>
    sys.exit(main())
             ~~~~^^
  File "/usr/lib/python3.13/site-packages/ugrd/main.py", line 169, in main
    generator = InitramfsGenerator(**kwargs)
  File "/usr/lib/python3.13/site-packages/zenlib/logging/loggify.py", line 12, in __init__
    super().__init__(*args, **kwargs)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/ugrd/initramfs_generator.py", line 32, in __init__
    self.load_config(config)  # The user config is loaded over the base config, clobbering kwargs
    ~~~~~~~~~~~~~~~~^^^^^^^^
  File "/usr/lib/python3.13/site-packages/ugrd/initramfs_generator.py", line 61, in load_config
    self[config] = value
    ~~~~^^^^^^^^
  File "/usr/lib/python3.13/site-packages/ugrd/initramfs_generator.py", line 69, in __setitem__
    self.config_dict[key] = value
    ~~~~~~~~~~~~~~~~^^^^^
  File "/usr/lib/python3.13/site-packages/ugrd/initramfs_dict.py", line 79, in __setitem__
    return self.handle_parameter(key, value)
           ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/ugrd/initramfs_dict.py", line 113, in handle_parameter
    return getattr(self, f"_process_{key}")(value)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^
  File "/usr/lib/python3.13/site-packages/zenlib/util/handle_plural.py", line 29, in wrapper
    function(self, *(other_args + (item,)), **kwargs)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/ugrd/initramfs_dict.py", line 370, in _process_modules
    self[name] = value
    ~~~~^^^^^^
  File "/usr/lib/python3.13/site-packages/ugrd/initramfs_dict.py", line 79, in __setitem__
    return self.handle_parameter(key, value)
           ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/ugrd/initramfs_dict.py", line 132, in handle_parameter
    return handle_plural(func)(self, value)
           ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/zenlib/util/handle_plural.py", line 29, in wrapper
    function(self, *(other_args + (item,)), **kwargs)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/ugrd/base/core.py", line 463, in _process_binaries_multi
    dependencies = calculate_dependencies(self, binary)
  File "/usr/lib/python3.13/site-packages/ugrd/base/core.py", line 149, in calculate_dependencies
    raise AutodetectError("Unable to resolve dependencies, error: %s" % dependencies.stderr.decode("utf-8"))
ugrd.exceptions.AutodetectError: Unable to resolve dependencies, error: lddtree: warning: /usr/sbin/plymouth-set-default-theme: Magic number does not match

Based on the history of the file "/usr/sbin/plymouth-set-default-theme" from plymouth, it looks like it's always been a bash/shell script.

My understanding is that lddtree only works with ELF formatted files

I can see here that the variable "binary_path" is assigned "/usr/bin/plymouth-set-default-theme" and later variable "interpreter" is assigned "/bin/bash", however after updating the binaries list, ugrd runs lddtree based on "binary_path", hence the "Magic number does not match"

If I'm understanding this correctly, this won't with any none ELF formatted files that are registered as binaries

loving ugrd, thanks for the effort

[desultory]

are you using the python USE flag on pax-utils? I think that will make it install a lddtree binary which acts a bit differently.

the non-python lddtree tends to handle failures like this a bit more safely

[sinatosk]

I have app-misc/pax-utils-1.3.8 installed and the python flag is by default ( I didn't explicitly enable it ) yes

I'm interpreting what your saying as to disable that?

edit: I take that back, I did enable it globally ( make.conf )

[sinatosk]

Just rebuilt app-misc/pax-utils-1.3.8 with python flag disabled, it works

INFO | [plymouth-set-default-theme] Adding interpreter to binaries: /bin/bash

thanks

[desultory]

Just rebuilt app-misc/pax-utils-1.3.8 with python flag disabled, it works

INFO | [plymouth-set-default-theme] Adding interpreter to binaries: /bin/bash

thanks

thanks for testing, I'm moderately interested in trying to make it handle both tools, but I've only ever seen the python versions used by accident :P

[sinatosk]

Sounds like until ugrd can handle both tools, Gentoo package ( sys-kernel/ugrd ) should provide a warning or error about app-misc/pax-utils and python flag when registering non ELF formatted binaries if using ?

If so, I might make a suggestion to the maintainers and refer them to this issue on why they should consider doing that, probably just print a message at the end of merge

[desultory]

Sounds like until ugrd can handle both tools, Gentoo package ( sys-kernel/ugrd ) should provide a warning or error about app-misc/pax-utils and python flag when registering non ELF formatted binaries if using ?

If so, I might make a suggestion to the maintainers and refer them to this issue on why they should consider doing that, probably just print a message at the end of merge

yeah that's one way to handle this. The underlying issue should probably be addressed though. I think this an issue on debian systems in particular as well, because debian defaults to using the python variant of lddtree from pax-utils.

ugrd could do something to try to determine which type of lddtree is installed before using it, and handle that accordingly.

[sinatosk]

Looking here ( lines 119-129 ) and in the source tree I see lddtree.sh and lddtree.py, lddtree is implemented as bash and python

I'm not sure for python yet ( py_compile or compileall modules maybe be used ), but for bash ( the preferred implementation ) "bash -n /bin/lddtree" can be used to verify bash syntax without execution and this is equivelant to

#!/bin/bash

set -n
// rest of lddtree bash script...

according to bash man page

Read commands but do not execute them.  This may be
used to check a shell script for syntax errors.
This is ignored by interactive shells.

I used "bash -n /bin/lddtree" and exit status is 0 on success, 2 on fail

[kambe-mikb]

I have two questions:
(1) Why is there a dependency on plymouth-set-default-theme at all? Why is this needed during boot?
(2) If you are going to run lddtree on non ELF files, shouldn't you make the command lddtree --skip-non-elfs ?

[desultory]

I have two questions: (1) Why is there a dependency on plymouth-set-default-theme at all? Why is this needed during boot? (2) If you are going to run lddtree on non ELF files, shouldn't you make the command lddtree --skip-non-elfs ?

i think if you want to be real proper, there are even more dependencies, plymouth prefers you actually run a tool it provides to copy dependencies into the initramfs.

I don't think the non-python version of lddtree supports that arg:

> lddtree $(command -v cat)
cat => /usr/bin/cat (interpreter => /lib64/ld-linux-x86-64.so.2)
    libc.so.6 => /usr/lib64/libc.so.6
        ld-linux-x86-64.so.2 => /lib64/ld-linux-x86-64.so.2
> lddtree --skip-non-elfs $(command -v cat)
Display ELF dependencies as a tree

Usage: lddtree [options] <ELF file[s]>

Options:
  -a              Show all duplicated dependencies
  -x              Run with debugging
  -R <root>       Use this ROOT filesystem tree
  --no-auto-root  Do not automatically prefix input ELFs with ROOT
  -l              Display output in a flat format
  -h              Show this help output
  -V              Show version information

as far as I can tell, the cleanest way to approach this is to do some check first to determine the lddtree variant (im not a huge fan of this)