fix: update Makefile.am to conditionally set icons directory and handle missing icons for Emscripten builds

devMinseok · devMinseok · commit aa54f489e7e0 · 2025-11-15T16:10:07.000+09:00
diff --git a/data/Makefile.am b/data/Makefile.am
@@ -14,12 +14,12 @@ EXTRA_DIST=              \
         wadfile.png      \
         convert-icon
 
-iconsdir = $(prefix)/share/icons/hicolor/128x128/apps
-
 # For Emscripten builds, skip hexen.png and strife.png if they don't exist
+@ENABLE_EMSCRIPTEN_TRUE@iconsdir = $(prefix)/share/icons/hicolor/128x128/apps
 @ENABLE_EMSCRIPTEN_TRUE@icons_DATA = @PROGRAM_PREFIX@doom.png    \
 @ENABLE_EMSCRIPTEN_TRUE@             @PROGRAM_PREFIX@heretic.png \
 @ENABLE_EMSCRIPTEN_TRUE@             @PROGRAM_PREFIX@setup.png
+@ENABLE_EMSCRIPTEN_FALSE@iconsdir = $(prefix)/share/icons/hicolor/128x128/apps
 @ENABLE_EMSCRIPTEN_FALSE@icons_DATA = @PROGRAM_PREFIX@doom.png    \
 @ENABLE_EMSCRIPTEN_FALSE@             @PROGRAM_PREFIX@heretic.png \
 @ENABLE_EMSCRIPTEN_FALSE@             @PROGRAM_PREFIX@hexen.png   \

-Original file line number
+Diff line change
         wadfile.png      \
         convert-icon
 -iconsdir = $(prefix)/share/icons/hicolor/128x128/apps
+-
 # For Emscripten builds, skip hexen.png and strife.png if they don't exist
 +@ENABLE_EMSCRIPTEN_TRUE@iconsdir = $(prefix)/share/icons/hicolor/128x128/apps
 @ENABLE_EMSCRIPTEN_TRUE@icons_DATA = @[email protected]    \
 @ENABLE_EMSCRIPTEN_TRUE@             @[email protected] \
 @ENABLE_EMSCRIPTEN_TRUE@             @[email protected]
 +@ENABLE_EMSCRIPTEN_FALSE@iconsdir = $(prefix)/share/icons/hicolor/128x128/apps
 @ENABLE_EMSCRIPTEN_FALSE@icons_DATA = @[email protected]    \
 @ENABLE_EMSCRIPTEN_FALSE@             @[email protected] \
 @ENABLE_EMSCRIPTEN_FALSE@             @[email protected]   \