🐛 Fix: favorite not working when empty

devaryakjha · Oct 23, 2023 · bf43982 · bf43982
1 parent dc13439
commit bf43982
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/lib/features/user-library/data/user_library.dart b/lib/features/user-library/data/user_library.dart
@@ -113,7 +113,9 @@ final class Favorite extends UserLibrary {
 
   static const String boxKey = "favorite";
 
-  const Favorite.empty() : super.empty(UserLibraryType.favorite);
+  factory Favorite.empty() {
+    return const Favorite(mediaItems: []);
+  }
 }
 
 @HiveType(typeId: 20)
@@ -125,8 +127,6 @@ final class AlbumLibrary extends UserLibrary {
     required super.mediaItems,
     required super.images,
   }) : super(type: UserLibraryType.album);
-
-  const AlbumLibrary.empty() : super.empty(UserLibraryType.album);
 }
 
 @HiveType(typeId: 21)
@@ -138,6 +138,4 @@ final class PlaylistLibrary extends UserLibrary {
     required super.mediaItems,
     required super.images,
   }) : super(type: UserLibraryType.playlist);
-
-  const PlaylistLibrary.empty() : super.empty(UserLibraryType.playlist);
 }
diff --git a/lib/features/user-library/data/user_library_repository.dart b/lib/features/user-library/data/user_library_repository.dart
@@ -36,8 +36,8 @@ class UserLibraryRepository {
   Future<void> favoriteSong(Song song) async {
     final favourites = _box.get(
       Favorite.boxKey,
-      defaultValue: const Favorite.empty(),
-    ) as UserLibrary;
+      defaultValue: Favorite.empty(),
+    )!;
     final newFavourites = favourites.copyWith(
       mediaItems: [...favourites.mediaItems, song],
     );
@@ -47,8 +47,8 @@ class UserLibraryRepository {
   Future<void> unfavoriteSong(Song song) async {
     final favourites = _box.get(
       Favorite.boxKey,
-      defaultValue: const Favorite.empty(),
-    ) as UserLibrary;
+      defaultValue: Favorite.empty(),
+    )!;
     final newFavourites = favourites.copyWith(
       mediaItems: favourites.mediaItems.where((e) => e.id != song.id).toList(),
     );