Semantic error in unit test MatchesIsNotInEnumerable()?

[praeceptum]

Regarding the class Moq.Tests.MatchersFixture, given that the setups in the unit test method MatchesIsInVariadicParameters() are:

mock.Setup(x => x.Echo(It.IsIn(1, 2, 3, 4, 5))).Returns(1);
mock.Setup(x => x.Echo(It.IsIn(6, 7, 8, 9, 10))).Returns(2);

then the ranges in MatchesIsNotInEnumerable():

mock.Setup(x => x.Echo(It.IsNotIn(Enumerable.Range(1, 5)))).Returns(1);
mock.Setup(x => x.Echo(It.IsNotIn(Enumerable.Range(6, 10)))).Returns(2);

were probably meant to be:

mock.Setup(x => x.Echo(It.IsNotIn(Enumerable.Range(1, 5)))).Returns(1);
mock.Setup(x => x.Echo(It.IsNotIn(Enumerable.Range(6, 5)))).Returns(2);

since the signature is Range(int start, int count), not Range(int start, int end).
 
 
The same is probably true for MatchesIsInEnumerable() given the ranges in MatchesRanges(), except that the latter is using an exclusive range for the second sequence.

[github-actions]

Due to lack of recent activity, this issue has been labeled as 'stale'.
It will be closed if no further activity occurs within 30 more days.
Any new comment will remove the label.

[praeceptum]

(bump)

[pedwards1]

Hi! I took a look at this issue and it appears to have already been fixed in PR #1496 (merged back in August 2024).

From what I can see in the current main branch (commit 0fea50e), both test methods now correctly use Enumerable.Range(6, 5) instead of Enumerable.Range(6, 10):

MatchesIsInEnumerable() - Line 73
MatchesIsNotInEnumerable() - Line 124
I ran the tests locally and all 124 tests in MatchersFixture are passing, so it looks like everything is working as expected now.

I think this issue can probably be closed

[praeceptum]

Agreed.