Feedback

[denstorti]

2020-jun-project1-group2

Documentation:

• Good solution diagram versioned as text!

• Solution diagram:

  • (TBD) Could be bigger to fit well all components. Some of them can be hidden as they are not adding important meaning to the diagram, as NACLs and Route tables (unless you describe de routes with arrows or NACL rules).
  • (TBD) There are some components missing as:
    • ALB
    • Bastion host
    • EFS mount targets
    • (TBD) AWS CLI can be configured using profiles, at the moment it is requiring env vars.

  ERROR environment varaible: AWS_ACCESS_KEY_ID must be set.

  • (TBD) nothing mentioning this env var --> make plan error: ERROR environment varaible: TF_VAR_container_image_uri must be set
  • (TBD) Run steps order not fully documented: the image needs to be built with make build, then published. But for publishing the ECR repo needs to be created already (make plan apply). Remove validation above for TF_VAR_container_image_uri.
  • (TBD) (missing Automatic task scaling policies)
  • (TBD) 8 capacity units for Aurora serverless can be expensive. Set it to 1
    • (TBD) no instructions on how to destroy
    • (TBD) no logs for containers
    • (TBD) remove value DB password as env var in task definition
    • (TBD) terraform file names can improve as they should have a logical meaning not a technical one and maybe be group. For example, ecs.tf, ecr.tf, are related to frontend-app.

• Questions:

  • Does Key pair needs to be set up manually as part of the set up?
  • AWS CLI configuration only accepting env vars?
  • Why a bastion host?
  • How do containers scale? (missing Automatic task scaling policies)
  • How do you see error logs in the app?

Good work, team! 🚀