Feedback

[denstorti]

2020-jun-project1-group3

Good points:

• README badges are cool and help with collaboration :D
• Good to have the extra /docs with manual steps you followed

Solution diagram:

• (TBD) change from Fargate cluster to ECS cluster (backed by Fargate computing). ASG is internal in Fargate, can be removed from diagram.
• (TBD) EFS can be break down in mount targets per AZ
• (TBD) If Aurora is running in the same private subnets as the containers, reuse the same rectangle of Private Subnets.
• (TBD) Missing ACM in the Diagram
• (TBD) ALB is deployed in public subnets, routing to private subnets. Make it more explicit in the diagram.
• (TBD) Good to have the additional services on the right but not sure how they participate in the solution. Is it possible to make it clearer by having arrows connecting them?

Running:

• (TBD) not clear in the pre-requisites what's needed to run the solution (doesn't ask for S3 buckets, domains, or hosted zones), and when the person gets to the configuration section and the variables below are asked, it is confusing:

acm_cert_arn
AWS_ACCESS_KEY_ID
AWS_SECRET_ACCESS_KEY
domain_name
hosted_zone_id
ssh_allowed_cidr
tf_backend_bucket

• (TBD) Although you have the extra documentation it is not really linked in the README so the reader can just follow through the docs. They are just listed.
• (TBD) Use 3 Musketeers (specially docker-compose) to avoid local installations. Multiple Makefiles can make structure more complex. Also, scripting in Makefile instead of individual script files can lead to coupling with tools (what if you don't want to use terraform anymore but Cloudformation)
• I did the export with the bucket name. Error with S3 bucket during make deploy:

Error: Error loading state:
  InvalidParameter: 1 validation error(s) found.
minimum field size of 1, GetObjectInput.Bucket.

Terraform failed to load the default state from the "s3" backend.
State migration cannot occur unless the state can be loaded. Backend
modification and state migration has been aborted. The state in both the
source and the destination remain unmodified. Please resolve the
above error and try again.

Questions:

• Do terraform, jq, and AWS CLI need to be installed in the dev machine? Leverage 3M

Good work, team! 🚀