Skip to content

Commit fa11a88

Browse files
authored
Merge pull request #213 from devping-kr/dev
deploy
2 parents a932e59 + 3fee701 commit fa11a88

File tree

3 files changed

+17
-7
lines changed

3 files changed

+17
-7
lines changed

src/main/java/devping/nnplanner/domain/auth/controller/AuthController.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import devping.nnplanner.domain.auth.dto.request.AuthSignRequestDTO;
44
import devping.nnplanner.domain.auth.dto.request.EmailCodeRequestDTO;
55
import devping.nnplanner.domain.auth.dto.request.EmailRequestDTO;
6+
import devping.nnplanner.domain.auth.dto.request.GoogleLoginRequestDTO;
67
import devping.nnplanner.domain.auth.dto.response.AuthResponseDTO;
78
import devping.nnplanner.domain.auth.dto.response.AuthTokenResponseDTO;
89
import devping.nnplanner.domain.auth.service.AuthService;
@@ -21,7 +22,6 @@
2122
import org.springframework.web.bind.annotation.RequestBody;
2223
import org.springframework.web.bind.annotation.RequestHeader;
2324
import org.springframework.web.bind.annotation.RequestMapping;
24-
import org.springframework.web.bind.annotation.RequestParam;
2525
import org.springframework.web.bind.annotation.RestController;
2626

2727
@RequestMapping("/api/auths")
@@ -90,9 +90,9 @@ public ResponseEntity<ApiResponse<String>> loginUrlGoogle() {
9090

9191
@GetMapping("/oauth2/google")
9292
public ResponseEntity<ApiResponse<AuthResponseDTO>> loginGoogle(
93-
@RequestParam(value = "code") String authCode) {
93+
@RequestBody @Valid GoogleLoginRequestDTO googleLoginRequestDTO) {
9494

95-
AuthResponseDTO authResponseDTO = authService.loginGoogle(authCode);
95+
AuthResponseDTO authResponseDTO = authService.loginGoogle(googleLoginRequestDTO);
9696

9797
return GlobalResponse.OK("구글 로그인 성공", authResponseDTO);
9898
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
package devping.nnplanner.domain.auth.dto.request;
2+
3+
import lombok.Getter;
4+
5+
@Getter
6+
public class GoogleLoginRequestDTO {
7+
8+
private String authCode;
9+
}

src/main/java/devping/nnplanner/domain/auth/service/AuthService.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import devping.nnplanner.domain.auth.dto.request.AuthSignRequestDTO;
44
import devping.nnplanner.domain.auth.dto.request.GoogleInfoResponseDTO;
5+
import devping.nnplanner.domain.auth.dto.request.GoogleLoginRequestDTO;
56
import devping.nnplanner.domain.auth.dto.request.GoogleRequestDTO;
67
import devping.nnplanner.domain.auth.dto.request.GoogleResponseDTO;
78
import devping.nnplanner.domain.auth.dto.response.AuthResponseDTO;
@@ -96,20 +97,20 @@ public void logout(HttpServletRequest httpRequest, UserDetailsImpl userDetails)
9697

9798
public String loginUrlGoogle() {
9899
return "https://accounts.google.com/o/oauth2/v2/auth?client_id=" + googleClientId
99-
+ "&redirect_uri=" + oauthUrl + "/api/auths/oauth2/google"
100+
+ "&redirect_uri=" + oauthUrl
100101
+ "&response_type=code&scope=email%20profile%20openid&access_type=offline";
101102
}
102103

103-
public AuthResponseDTO loginGoogle(String authCode) {
104+
public AuthResponseDTO loginGoogle(GoogleLoginRequestDTO googleLoginRequestDTO) {
104105

105106
RestTemplate restTemplate = new RestTemplate();
106107

107108
GoogleRequestDTO googleOAuthRequestParam = GoogleRequestDTO
108109
.builder()
109110
.clientId(googleClientId)
110111
.clientSecret(googleClientPw)
111-
.code(authCode)
112-
.redirectUri(oauthUrl + "/api/auths/oauth2/google")
112+
.code(googleLoginRequestDTO.getAuthCode())
113+
.redirectUri(oauthUrl)
113114
.grantType("authorization_code")
114115
.build();
115116

0 commit comments

Comments
 (0)