Misleading concept using subscription #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

windmaomao opened this issue Sep 16, 2017 · 0 comments

windmaomao commented Sep 16, 2017

If this component is created for promise or one time subscription, it's fine.

But normally whenever subscription is mentioned, people assume it's a continuous stream. And to be honest, spinner in angular should be designed using observable, because application wise spinner is not a one time thing. Ex. https://hassantariqblog.wordpress.com/2016/12/03/angular2-using-loaderspinner-as-angular-service-in-angular-2-application/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment