ERROR: TypeError: '<=' not supported between instances of 'int' and 'str'

[Hadatko]

I made modification to see why i am getting this error

With result
1
MASK
254
2024-02-02 20:11:24,767 ERROR: TypeError: '<=' not supported between instances of 'int' and 'str'

[Hadatko]

After this change i am able to control my dali device

diff --git a/dali2mqtt/lamp.py b/dali2mqtt/lamp.py
index 272948d..581c97f 100644
--- a/dali2mqtt/lamp.py
+++ b/dali2mqtt/lamp.py
@@ -90,6 +90,14 @@ class Lamp:
     @level.setter
     def level(self, value):
         """Commit level to ballast."""
+        if not isinstance(value, (int, float)):
+                   logger.warning(f"The value '{value}' is not a number")
+            self.__level = 1
+            return
+        
+        print(self.min_level)
+        print(value)
+        print(self.max_level)
         if not self.min_level <= value <= self.max_level and value != 0:
             raise ValueError
         self.__level = value

[dgomes]

Why are you setting the level of the light to "MASK" ?!

it should be a number 0..255

[Hadatko]

I am not doing anything :D It is your code :D I am just debugging it

[dgomes]

For that debug message to appear, you have published "MASK" to the MQTT topic

[Hadatko]

Only if homeassistant is doing that without my knowledge which i doubt. Only if that is some handshake issue. But only i did so far was running your code.
But maybe there can be another issue i will try to confirm. My container name is same as your project. And i am tracking information about containers using some HA integration. So maybe there is some conflict in topics.

[dgomes]

Did you do any sort of configuration in Home Assistant ? Because the daemon should have configured all the devices for you, without any human intervention.

[Hadatko]

Hmm that is weird but MASK string issue disappeared too. So confusing. I will let you know if i will notice it once again.
But i think some fix similar i did would be good to be sure data are correct.

[Hadatko]

No these errors appeared directly after running your python code. Didn't have time to go and do something in HA

[dgomes]

A warning should be logged indeed, but I advise against setting an arbitrary level. Would you like to open a PR ?

[Hadatko]

Yes sure. Just to clarify the MASK word always appeared at the beginning when i run code. But if i kept it running and was doing changes using HA all values were correct. But when i closed and run app again, i got MASK word again and then it worked ok again. Sorry for a lot of "again" words. Now the word sometimes appear sometimes not at the beginning of running application.

[Hadatko]

Once i will have more time i will try to debug it more why it appear randomly at the beginning.

[dgomes]

there is no "MASK" in my code 😬

and worst... that setter is called at https://github.com/dgomes/dali2mqtt/blob/master/dali2mqtt/dali2mqtt.py#L276 which does a cast to int... so no string should have ever reached the setter.

[dgomes]

I'm available at Home Assistant discord with the same handle as here, if you would like to reach out to expedite debug

[Hadatko]

I appretiate your offer ;) And also how quick are you responding.
Do you think these level cals may not cause the issue with mask?

[Hadatko]

The bottom one doesn't have ".value" postfix call as the upper once

[dgomes]

variable is different... it's __level not level

but if the error is coming from that part of the code it means the driver (Tridonic) is storing "MASK" instead of a value..... again the issue is in python-dali... it need to be standardised there IMHO

[Hadatko]

Not sure if this is related byt found this in python-dali:

[dgomes]

Not doing any Colour queries... would find quite odd to ask for brightness and the driver returning colour :/

[Hadatko]

So we need handle that differently as "MASK" word is intended

[dgomes]

Where is that ? (better link code then to attach screenshots...)

[Hadatko]

https://github.com/sde1000/python-dali/blob/0ebccd7ed46f2a6bb581f1f4c9c8937181f43ea2/dali/gear/general.py#L796

https://github.com/sde1000/python-dali/blob/0ebccd7ed46f2a6bb581f1f4c9c8937181f43ea2/dali/command.py#L90

[hichemsystem1]

dear
I am a smart home integrator and installer. I am currently working on a project to develop a Matter-DALI2 bridge (M2D Bridge) using an ESP32 module.

I am designing this bridge with specific features, such as the automatic detection of DALI drivers, their identification, address assignment, and determining their type (DT6 or DT8). My goal is also to enable control via Matter.
Since I am not a professional developer, I find myself a bit overwhelmed by some of the technical aspects of this integration. Therefore, I am reaching out to you, as I believe your expertise and experience with the dali2hass project could provide me with valuable assistance.
Thank you in advance for your time and consideration. I hope to discuss this project with you and benefit from your advice.

[Hadatko]

@hichemsystem1 Hi, i guess you are trying to reach owner.

[dgomes]

Please don't post messages unrelated to the issue.

@hichemsystem1 you can reach me out on Home Assistant Discord https://www.home-assistant.io/join-chat I go by @dgomes

@Hadatko sorry, never followed up on this :/

[Hadatko]

Sorry for spam. No problem, i didn't work on that since then.