Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Playwright and Puppeteer to use new headless mode by default #73

Closed
dgrebb opened this issue Dec 21, 2023 · 3 comments
Closed

Set Playwright and Puppeteer to use new headless mode by default #73

dgrebb opened this issue Dec 21, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request feature-request

Comments

@dgrebb
Copy link
Owner

dgrebb commented Dec 21, 2023

Let's make the full change in source to use new headless mode as the default.

Test regressions, test fallbacks, and ensure support for old mode is supported when new becomes vendor standard.

Notes

@dgrebb dgrebb self-assigned this Dec 21, 2023
@dgrebb dgrebb added enhancement New feature or request feature-request labels Dec 21, 2023
@dgrebb dgrebb added this to the Core Enhancements milestone Dec 21, 2023
@dgrebb
Copy link
Owner Author

dgrebb commented Dec 21, 2023

@garris let's discuss this - I see some evidence that new headless is actually slower.

It appears that one can pass headless: old as the mode, which apparently silences the deprecation warnings.

Maybe that's an option for now? The Chromium team says "we're going to make that the default later this year" back in January. So ¯_(ツ)_/¯

I'll look into ways perf testing can be done.

@garris
Copy link
Collaborator

garris commented Dec 22, 2023

Few thoughts.

  1. pretty sure this is exposed in engineOptions so risk of defaulting this to the "wrong" setting is fairly low.
  2. we should probably default this to headless: new but provide code snippet in docs for users who might hit an incompatibility.
  3. backstop stashes time started and time completed and spits out duration into the CLI. So testing for performance should be pretty easy. You could run sanity test sequentially 20 times and grep for the timing value to get a cumulative average.
  4. I'm open to other approaches. Just sharing gut reactions. Cheers.

@dgrebb
Copy link
Owner Author

dgrebb commented Dec 31, 2023

Closed by garris#1535

Super happy I haven't caused any nightmares yet.

@dgrebb dgrebb closed this as completed Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature-request
Projects
None yet
Development

No branches or pull requests

2 participants