Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: CI - Add report.json fixtures for each variety GH Actions tests #82

Open
dgrebb opened this issue Dec 23, 2023 · 1 comment
Open

[FEAT]: CI - Add report.json fixtures for each variety GH Actions tests #82

dgrebb opened this issue Dec 23, 2023 · 1 comment
Assignees
@dgrebb @garris
Labels
enhancement New feature or request
Milestone
GitHub Actions an...

Comments

@dgrebb
Copy link
Owner

dgrebb commented Dec 23, 2023 •
edited
Loading

garris#1533

We need more reliable pass/fail criteria for GitHub actions. Because mismatch errors trigger exit 1, GitHub will always fail.

  • add continue-on-error to all tests
  • generate test fixtures
  • add "if test fixture does not match output" conditional to hard-fail tests
@dgrebb dgrebb self-assigned this Dec 23, 2023
@dgrebb dgrebb added this to the GitHub Actions and CI/CD milestone Dec 23, 2023
@dgrebb dgrebb added the enhancement New feature or request label Dec 23, 2023
@dgrebb dgrebb pinned this issue Dec 23, 2023
@dgrebb
Copy link
Owner Author

dgrebb commented Jan 17, 2024

garris#1537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgrebb dgrebb

@garris garris

Labels
enhancement New feature or request
Projects
None yet
Milestone
GitHub Actions and CI/CD
Development

No branches or pull requests
2 participants
@dgrebb @garris