You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Let's allow the backstopjs package installation to be passable in args during Docker build.
Why?
This will allow GitHub actions to pass the current backstopjs branch to Docker, so build, publish, and tests are run with the latest changes this branch has introduced.
How?
rename the DockerfileARG "BACKSTOPJS_VERSION" → "BACKSTOP_INSTALL_SOURCE"
adjust the ENV BACKSTOPJS_VERSION=$BACKSTOPJS_VERSION → BACKSTOP_INSTALL_SOURCE=$BACKSTOP_INSTALL_SOURCE
adjust npm scripts as needed
create GitHub Actions var BACKSTOP_INSTALL_SOURCE to concatenate installation source path
update GitHub Actions to pass the BACKSTOP_INSTALL_SOURCE to Docker builds
check if any $TAGs need to be adjusted
The text was updated successfully, but these errors were encountered:
@garris FYA — another improvement for your consideration. This would include any changes to backstopjswithin Docker as part of the overall regression suite.
Currently one must commit a change to Dockerfile to include a GitHub branch path to test changes within npm backstop itself:
Summary
Let's allow the
backstopjs
package installation to be passable in args during Docker build.Why?
This will allow GitHub actions to pass the current backstopjs branch to Docker, so
build
,publish
, and tests are run with the latest changes this branch has introduced.How?
Dockerfile
ARG
"BACKSTOPJS_VERSION
" → "BACKSTOP_INSTALL_SOURCE
"ENV BACKSTOPJS_VERSION=$BACKSTOPJS_VERSION
→BACKSTOP_INSTALL_SOURCE=$BACKSTOP_INSTALL_SOURCE
npm
scripts as neededBACKSTOP_INSTALL_SOURCE
to concatenate installation source pathBACKSTOP_INSTALL_SOURCE
to Docker builds$TAG
s need to be adjustedThe text was updated successfully, but these errors were encountered: