Skip to content

Commit 4602d11

Browse files
committed
doesnt need to be set in the fetcher anymore
1 parent 1a0a478 commit 4602d11

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

changedetectionio/content_fetchers/requests.py

-5
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,6 @@ def run(self,
3030
if self.browser_steps_get_valid_steps():
3131
raise BrowserStepsInUnsupportedFetcher(url=url)
3232

33-
# Make requests use a more modern looking user-agent
34-
if not {k.lower(): v for k, v in request_headers.items()}.get('user-agent', None):
35-
request_headers['User-Agent'] = os.getenv("DEFAULT_SETTINGS_HEADERS_USERAGENT",
36-
'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.66 Safari/537.36')
37-
3833
proxies = {}
3934

4035
# Allows override the proxy on a per-request basis

changedetectionio/model/App.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
)
77

88
_FILTER_FAILURE_THRESHOLD_ATTEMPTS_DEFAULT = 6
9+
DEFAULT_SETTINGS_HEADERS_USERAGENT='Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.66 Safari/537.36'
910

1011
class model(dict):
1112
base_config = {
@@ -23,7 +24,7 @@ class model(dict):
2324
'timeout': int(getenv("DEFAULT_SETTINGS_REQUESTS_TIMEOUT", "45")), # Default 45 seconds
2425
'workers': int(getenv("DEFAULT_SETTINGS_REQUESTS_WORKERS", "10")), # Number of threads, lower is better for slow connections
2526
'default_ua': {
26-
'html_requests': None,
27+
'html_requests': getenv("DEFAULT_SETTINGS_HEADERS_USERAGENT", DEFAULT_SETTINGS_HEADERS_USERAGENT),
2728
'html_webdriver': None,
2829
}
2930
},

0 commit comments

Comments
 (0)