Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

204 'No Content' Status Code (Success for InfluxDB) on Notifications is considered failure #2896

Closed
guicattani opened this issue Jan 10, 2025 · 1 comment · Fixed by #2897
Assignees
Labels

Comments

@guicattani
Copy link

guicattani commented Jan 10, 2025

Describe the bug

Whenever InfluxDB receives data correctly it returns a 204 status code, but Change Detection notification considers that status code as an error.

Version
v0.48.06

How did you install?
Docker Container

To Reproduce

Steps to reproduce the behavior:

  1. Spin up a InfluxDB with an API key
  2. Add something like:
post://influxdb:8086/api/v2/write?org=testorg&bucket=test&+Authorization=Token TESTTOKEN

in the Notification URL List

test,testlabel=thisisatest,testlabel=thisisatest open_positions={{current_snapshot}}

in the Notification Body
4. Save and let the watcher run
5. See that the watcher failed with error

Expected behavior
2xx status codes should probably be considered success

Screenshots
image

Desktop (please complete the following information):

  • OS: Linux
  • Browser Firefox
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version 133.0

Thank you so much :)
Let me know if you need anything else. And thanks again for this amazing project 😁

@dgtlmoon
Copy link
Owner

Oops! thanks for the solid report, will drop a new release ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants