36-feat-card-transactions #48
Conversation
…ion was handled correctly
|
Hey @parthux1 ,
Test cases contain all responses and their "normalized" state. With that it will help both you and me to make sure that changes are working. Again, if you need help, we can chat and I can help you setting it up. |
|
FYI; I'm currently moving. I'll implement your suggestions as soon as I'm done and have my new wifi. |
…rteile"
Headers correspond to the UI elements with the same naming in the TR-App when viewing a payment transcation.
"Vorteile":
contains potential saveback payments.
Example
```
{
"data": [
{
"detail": {
"action": {
"type": "benefitsSavebackOverview"
},
"amount": "XXX €",
"icon": "logos/IE0031442068/v2",
"status": "executed",
"subtitle": "Saveback",
"timestamp": "2024-04-07T18:03:34.802+0000",
"title": "Core S\u0026P 500 USD (Dist)",
"type": "embeddedTimelineItem"
},
"style": "plain",
"title": "Core S\u0026P 500 USD (Dist)"
}
],
"title": "Vorteile",
"type": "table"
}
```
"Hilfe":
contains transction ids
Example
```
{
"data": [
{
"detail": {
"action": {
"payload": {
"contextCategory": "card-dispute",
"contextParams": {
"card-dispute-txId": "XXXXXXXXXXXXXXXXXXXXXXXXXX"
},
"transactionId": "XXXXXXXXXXXXXXXXXXXXXXXXX"
},
"type": "customerSupportChat"
},
"icon": "logos/timeline_communication/v2",
"type": "listItemAvatarDefault"
},
"style": "highlighted",
"title": "Problem melden"
}
],
"title": "Hilfe",
"type": "table"
}
```
|
Hello dhojayev, both linked test cases seem to be for testing the unimplemented feature I'm currently working on. In my last commit I appended data for all parameters of Even when looking at a similar test I don't understand what should be stored in ``TimelineTransactionsData`. I tried adding the content of json element "data" (line 66 in commited tests/fakes/card_successful_transaction_01.go) which causes the same issue. Thus it's not present in the commit. Maybe you could point me in the right direction regarding this issue. |
closes #36
As of now the implementation writes Card payment information to the already generated CSV.
Polluted fields:
whats missing for this PR to be closed (IMO)
I hope I utilized the corresponding patterns correctly and sticked to your style. As it's my first time writing Go I'd be grateful if you comment if you see a problem with the used style&approaches.