Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal.Block instead of Modal.Header and Modal.Footer #2522

Closed
eirikbacker opened this issue Sep 26, 2024 · 0 comments · Fixed by #2583
Closed

Modal.Block instead of Modal.Header and Modal.Footer #2522

eirikbacker opened this issue Sep 26, 2024 · 0 comments · Fixed by #2583
Labels
css @digdir/designsystemet-css react @digdir/designsystemet-react

Comments

@eirikbacker
Copy link
Contributor

To match Card API, see: #2509
@eirikbacker eirikbacker converted this from a draft issue Sep 26, 2024
@eirikbacker eirikbacker moved this from 🔵 Inbox to 📄 Todo in Team Design System Sep 26, 2024
@eirikbacker eirikbacker added react @digdir/designsystemet-react css @digdir/designsystemet-css labels Sep 26, 2024
@eirikbacker eirikbacker mentioned this issue Sep 26, 2024
Merged
eirikbacker added a commit that referenced this issue Oct 1, 2024
@eirikbacker
fix(Card): api and a11y (#2509)
bf31bfc 
- Implements `Card.Block` to simplify API and make it more robust
- Allows putting content directly inside `<Card>`
- Allows putting `<a>` inside a heading instead of using `isLink` -
following
https://adrianroselli.com/2020/02/block-links-cards-clickable-regions-etc.html
for better accessibility
- Supports `<Card asChild><a></a></Card>` as an escape hatch for those
who really needs the whole card to be a link
- Supports `<Card asChild><button></button></Card>`
- Have verified new concept with Øyvind - and will replicate this API
for Modal: #2522
- Have verified that Card should have same border color regardless of
link or not with Lasse
@eirikbacker eirikbacker mentioned this issue Oct 8, 2024
Merged
@github-project-automation github-project-automation bot moved this from 📄 Todo to ✅ Done in Team Design System Oct 8, 2024
@github-project-automation github-project-automation bot moved this from 📄 Todo to ✅ Done in Team Design System Oct 8, 2024
unekinn pushed a commit that referenced this issue Oct 10, 2024
@eirikbacker @Barsnes @unekinn
fix(Modal): block (#2583)
04ad9e2 
Fixes #2522

---------

Co-authored-by: Tobias Barsnes <[email protected]>
unekinn pushed a commit that referenced this issue Oct 11, 2024
@eirikbacker @unekinn
fix(Card): api and a11y (#2509)
6c0e755 
- Implements `Card.Block` to simplify API and make it more robust
- Allows putting content directly inside `<Card>`
- Allows putting `<a>` inside a heading instead of using `isLink` -
following
https://adrianroselli.com/2020/02/block-links-cards-clickable-regions-etc.html
for better accessibility
- Supports `<Card asChild><a></a></Card>` as an escape hatch for those
who really needs the whole card to be a link
- Supports `<Card asChild><button></button></Card>`
- Have verified new concept with Øyvind - and will replicate this API
for Modal: #2522
- Have verified that Card should have same border color regardless of
link or not with Lasse
unekinn pushed a commit that referenced this issue Oct 11, 2024
@eirikbacker @Barsnes @unekinn
fix(Modal): block (#2583)
e5c80c5 
Fixes #2522

---------

Co-authored-by: Tobias Barsnes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css @digdir/designsystemet-css react @digdir/designsystemet-react
Projects
Team Design System
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Modal): block digdir/designsystemet
1 participant
@eirikbacker