-
Notifications
You must be signed in to change notification settings - Fork 3
chore: update production dependencies #1225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super helpful summary! Really appreciate having it as a reference. Good to see the removal of a couple unused deps.
Provided a couple of non-blocking suggestions, but otherwise liking how this looks 👍
found out about a removed dep that shouldn't be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I think the buffer
module needs to be restored unfortunately. other than that, my previous review still stands 😄
…asscode input typing. Patches the passcode masking because it was not working.
@achou11, So it looks like assert was also required as a dependency, here in particular: babel.config.js |
I'm surprised about the
Yes I'm aware - this is fine + intended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My note on the assert
question is not blocking - just me being particular about shaving deps if possible 😄 doesn't have any runtime consequences from what I can tell.
patches/README.md
Outdated
|
||
Fixes a bug in the `MaskSymbol` component where the mask (`*`) briefly un-hides when typing quickly. This patch sets the `visibleFlag` to `false` immediately, preventing the undesired flicker. | ||
|
||
See: [Reviewer context](https://github.com/recruiters/github/blob/master/README.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh. I meant to put in this PR as the link. Fixing.
@achou11 Ok I removed assert and changes the Readme and import in the babel file. Any idea why the lockfile test failed that time? |
have no idea. the |
* Upgrades to production dependencies. Fixes some things related to passcode input. * Removes assert. * Updates google font. * Removes unused dependency debug. Patches the passcode masking because it was not working.
… off (#1252) * chore: update production dependencies (#1225) * Upgrades to production dependencies. Fixes some things related to passcode input. * Removes assert. * Updates google font. * Removes unused dependency debug. Patches the passcode masking because it was not working. * feat: update @comapeo/core to 4.0.0 (#1231) * chore: audio improvements (#1212) * Audio refactor. * Changes screen name. Adds navigation from observation before it is saved. * Deletes unused audio files. * Makes thumbnails. Makes saved attachment player. * Consolidates styles, adjusts date on thumbnail. * Updates the audio tests. * Updates to new button component * Adds changes based on PR comments. * Moves audio permission into the audio component. Consolidates to one loading state not related to audio file logic. * Uses the new audio created at field for the UI for thumbnails and playback screen. * Removes unused reset method. * fix: remove leave project (#1239) * Removes the leave project screen and button. * fix: observation metadata no longer cut off (#1240) * Adjusts the observation metadata screen so that it is in a scrollview. * Tweaks to styling so it fits on small screens better. --------- Co-authored-by: cimigree <[email protected]> Co-authored-by: Andrew Chou <[email protected]>
close #1218
Monthly Production Dependency Upgrade
This PR updates production dependencies as part of our regular maintenance process using
npm run upgrade-deps:production
,depcheck
, andexpo-doctor
.Updated Packages
@expo-google-fonts/rubik
@gorhom/bottom-sheet
@react-navigation/bottom-tabs
@react-navigation/native
@react-navigation/stack
@tanstack/react-query
expo-build-properties
react-hook-form
react-native-confirmation-code-field
react-native-safe-area-context
react-native-screens
react-native-share
react-native-svg
valibot
zustand
Skipped Packages
@rnmapbox/maps
react-native-mmkv
expo-*
&react-native
@sentry/react-native
Removed Packages
These were identified as unused by
depcheck
and confirmed via manual review:expo-status-bar
react-native-android-open-settings
react-native-linear-gradient
assert
debug
Compatibility Checks (
expo-doctor
)npx expo-doctor
and reviewed 2 warnings:Validate Packages Metadata
react-native-restart
react-native-indicators
@comapeo/*
,valibot
, etc.)Version Mismatches with SDK, all downgrades
@react-native-picker/picker
react-native-gesture-handler
react-native-safe-area-context
react-native-screens
react-native-svg
Some fixes needed based on package changes
InputPasscode
to fix type errors.isLastFilledCell
inPasscodeInput
to match the updated function signature.react-native-confirmation-code-field
so that the masking of the passcode would work.@expo-google-fonts/rubik
to0.4.1
and fixed font paths inapp.json
to reflect new file structure requirements.Manual QA