[task/gh-44] for confirmations: added handling of missing fields and … (#63)

* [task/gh-44] for confirmations: added handling of missing fields and logging

* [task-gh-44] implemented more fields checks to address PR comments

Author: jophals

track/gbf.py

@@ -222,12 +222,12 @@ def get_order_confirmations(order_numbers):
     if "ShippingConfirmations" in confirmations:
         for shipping_confirmation in confirmations['ShippingConfirmations']:
             tracking_info[shipping_confirmation['OrderNumber']] = {
-                'date_kit_shipped': shipping_confirmation['ShipDate'],
-                'kit_tracking_n': shipping_confirmation['Tracking'],
+                'date_kit_shipped': shipping_confirmation['ShipDate'] if 'ShipDate' in shipping_confirmation else None,
+                'kit_tracking_n': shipping_confirmation['Tracking'] if 'Tracking' in shipping_confirmation else None,
                 #filter for items with return tracking numbers and returns tracking numbers
-                'return_tracking_n': [return_track for item in shipping_confirmation['Items'] if 'ReturnTracking' in item for return_track in item['ReturnTracking']],
+                'return_tracking_n': [return_track if 'Items' in shipping_confirmation else None for item in shipping_confirmation['Items'] if 'ReturnTracking' in item for return_track in item['ReturnTracking']],
                 #filter for items with return tracking numbers and returns tracking numbers
-                'tube_serial_n': [tube_serial for item in shipping_confirmation['Items'] if 'TubeSerial' in item for tube_serial in item['TubeSerial']]
+                'tube_serial_n': [tube_serial if 'Items' in shipping_confirmation else None for item in shipping_confirmation['Items'] if 'TubeSerial' in item for tube_serial in item['TubeSerial']]
             }  
     return tracking_info   
 

track/orders.py

@@ -100,7 +100,8 @@ def _update_orders_with_shipping_info(tracking_info):
                 continue
 
             # if order has not shipped yet, we don't need to continue
-            if not tracking_info[order.order_number]['date_kit_shipped']: 
+            if not tracking_info[order.order_number]['date_kit_shipped']:
+                logger.warning(f'Order {order.order_number} has no shipped date.') 
                 continue
 
             order.ship_date = tracking_info[order.order_number]['date_kit_shipped']
@@ -113,10 +114,16 @@ def _update_orders_with_shipping_info(tracking_info):
 
             if tracking_info[order.order_number]['kit_tracking_n']:
                 order.tracking_nrs = tracking_info[order.order_number]['kit_tracking_n']
+            else:
+                logger.warning(f'Order {order.order_number} has no tracking numbers.') 
             if tracking_info[order.order_number]['return_tracking_n']:
                 order.return_tracking_nrs = tracking_info[order.order_number]['return_tracking_n']
+            else:
+                logger.warning(f'Order {order.order_number} has no return tracking numbers.')
             if tracking_info[order.order_number]['tube_serial_n']:
                 order.tube_serials = tracking_info[order.order_number]['tube_serial_n']
+            else:
+                logger.warning(f'Order {order.order_number} has no tube serial numbers.')
             order.save()
 
     return shipped_orders