traverseCollectionItems() assumes nested collections have an items property (Presentation 3.0)

[mathewjordan]

If a presentation 3.0 Collection is loaded with vault, and that collection has an items array containing an item of type Collection, the error TypeError: can't access property "map", collection.items is undefined is shown as it assumes the nested collection in the items array to have its own items property. This doesn't seem to be an issue with presentation 2.0 collections as those are normalized and have an empty array.

const vault = new Vault();

vault
  .loadCollection("https://iiif.wellcomecollection.org/presentation/collections/archives")
  .then((collection) => {
    // collection...
  });

Would adding if checking for the collection.items prop catch this?

hyperion/packages/parser/src/traverse.ts

Lines 160 to 169 in 557d7b4

	traverseCollectionItems(collection: Collection): Collection {
	collection.items.map((collectionOrManifest: Manifest | Collection) => {
	if (collectionOrManifest.type === 'Collection') {
	return this.traverseCollection(collectionOrManifest as Collection);
	}
	return this.traverseManifest(collectionOrManifest as Manifest);
	});
	return collection;
	}

traverseCollectionItems(collection: Collection): Collection {
   if (collection.items) {
     collection.items.map((collectionOrManifest: Manifest | Collection) => { 
       if (collectionOrManifest.type === 'Collection') { 
         return this.traverseCollection(collectionOrManifest as Collection); 
       } 
       return this.traverseManifest(collectionOrManifest as Manifest); 
     }); 
   }
   
   return collection; 
} 

Thanks!!

[stephenwf]

Ah collection of collections! Yes that makes sense.