use toSlug from slugger package instead of our own implementation (#2153)

* use toSlug from slugger package instead of our own implementation

* remove toSlug tests

Author: mpscholten

ihp/IHP/NameSupport.hs

@@ -33,6 +33,7 @@ import Control.Monad (join)
 import qualified Text.Inflections
 import qualified Data.Text as Text
 import Text.Countable (singularize, pluralize)
+import qualified Data.Text.Slugger
 
 -- | Transforms a underscore table name to a camel case model name.
 --
@@ -245,17 +246,7 @@ haskellKeywords = [ "_"
 -- >>> toSlug "Hallo! @ Welt"
 -- "hallo-welt"
 toSlug :: Text -> Text
-toSlug text =
-        text
-        |> Text.toLower
-        |> Text.map replaceChar
-        |> Text.words
-        |> Text.intercalate "-"
-    where
-        replaceChar 'ä' = 'a'
-        replaceChar 'ö' = 'o'
-        replaceChar 'ü' = 'u'
-        replaceChar char = if Char.isAlphaNum char && Char.isAscii char then char else ' '
+toSlug text = Data.Text.Slugger.toSlug text
 
 
 -- | Transform a data-field name like @userName@  to a friendly human-readable name like @User name@

ihp/Test/NameSupportSpec.hs

@@ -113,16 +113,4 @@ tests = do
                 escapeHaskellKeyword "DATA" `shouldBe` "DATA_"
 
             it "should ignore non-haskell keywords" do
-                escapeHaskellKeyword "hello" `shouldBe` "hello"
-
-        describe "toSlug" do
-            it "should deal with empty input" do
-                toSlug "" `shouldBe` ""
-
-            it "should make a slug string from a string" do
-                toSlug "IHP Release: 21.08.2020 (v21082020)" `shouldBe` "ihp-release-21-08-2020-v21082020"
-                toSlug "Hallo! @ Welt" `shouldBe` "hallo-welt"
-            
-            it "should deal with umlaute" do
-                toSlug "käuferpass" `shouldBe` "kauferpass"
-                toSlug "äöüß" `shouldBe` "aou"
+                escapeHaskellKeyword "hello" `shouldBe` "hello"

ihp/ihp.cabal

@@ -136,6 +136,7 @@ common shared-properties
             , stm
             , wai-asset-path
             , wai-flash-messages
+            , slugger
     default-extensions:
         OverloadedStrings
         , NoImplicitPrelude