Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrations with a WP plugin #8

Open
wycks opened this issue Jul 9, 2013 · 4 comments
Open

Integrations with a WP plugin #8

wycks opened this issue Jul 9, 2013 · 4 comments

Comments

@wycks
Copy link
Contributor

wycks commented Jul 9, 2013

I hope you don't mind I forked this into a WP plugin https://github.com/wycks/WP-Pretty-Debug

Not sure what your plans are but I can maintain it with your upstream changes, there are some CSS issues with inline debugging that I'm not sure how to tackle, so far I'm just using an extra CSS style sheet to over ride.

Should I put some work into it or are you planning on doing a plugin with it? I don't want to step on anyones toes considering you created it.

@digitalnature
Copy link
Owner

Go ahead, I don't mind at all :)

I should mention that some of the HTML markup and CSS might change. I'm currently working on a different way to generate the output to keep memory usage to minimum when querying very large data...

@wycks
Copy link
Contributor Author

wycks commented Jul 9, 2013

No worries since I can pull in your changes and my CSS changes are minor and included in a separate file. The problem was it was hard to read when inline theme debugging, so I made it look like this, https://github.com/wycks/WP-Pretty-Debug/blob/master/screenshot.jpg

@digitalnature
Copy link
Owner

I see you're including the styles yourself. You should disable internal styles with ref::config('stylePath', false) if you do that. Then you can avoid !important. Same with the js if you want to use wp_enqueue_script()...

@wycks
Copy link
Contributor Author

wycks commented Jul 11, 2013

Ya I think I will do that thanks. btw I threw this up on wordpress.org and since your name is in the readme it now links to your profile (didn't realize it would do that) if that is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants