Merge pull request #2476 from digma-ai/stop-reporting-refresh-failed-event

stop reporting refresh failed event Closes #2459

Author: shalom938

ide-common/src/main/kotlin/org/digma/intellij/plugin/auth/account/AbstractLoginHandler.kt

@@ -74,15 +74,23 @@ abstract class AbstractLoginHandler(protected val analyticsProvider: RestAnalyti
         } catch (e: Throwable) {
 
             warnWithException(e, "Exception in login {}, url {}", e, analyticsProvider.apiUrl)
-            ErrorReporter.getInstance().reportError("${javaClass.simpleName}.login", e, mapOf("login trigger" to trigger))
-            val errorMessage = ExceptionUtils.getNonEmptyMessage(e)
-            reportAuthPosthogEvent(
-                "login failed",
-                this.javaClass.simpleName,
-                trigger,
-                mapOf("user" to user, "error" to errorMessage)
+            ErrorReporter.getInstance().reportError(
+                "${javaClass.simpleName}.login", e, mapOf(
+                    "login trigger" to trigger,
+                    "user" to user
+                )
             )
 
+            withAuthManagerDebug {
+                val errorMessage = ExceptionUtils.getNonEmptyMessage(e)
+                reportAuthPosthogEvent(
+                    "login failed",
+                    this.javaClass.simpleName,
+                    trigger,
+                    mapOf("user" to user, "error" to errorMessage)
+                )
+            }
+
             LoginResult(false, null, ExceptionUtils.getNonEmptyMessage(e))
         }
     }
@@ -128,18 +136,29 @@ abstract class AbstractLoginHandler(protected val analyticsProvider: RestAnalyti
 
         } catch (e: Throwable) {
             warnWithException(e, "Exception in refresh {}", e)
-            ErrorReporter.getInstance().reportError("${javaClass.simpleName}.refresh", e, mapOf("refresh trigger" to trigger))
-            val errorMessage = ExceptionUtils.getNonEmptyMessage(e)
-            reportAuthPosthogEvent(
-                "refresh token failed", this.javaClass.simpleName, trigger, mapOf(
-                    "error" to errorMessage,
+            ErrorReporter.getInstance().reportError(
+                "${javaClass.simpleName}.refresh", e, mapOf(
+                    "refresh trigger" to trigger,
                     "account.id" to account.id,
                     "accessTokenHash" to credentials.accessTokenHash(),
                     "refreshTokenHash" to credentials.refreshTokenHash(),
                     "expirationDate" to credentials.getExpirationTimeAsDate()
                 )
             )
 
+            withAuthManagerDebug {
+                val errorMessage = ExceptionUtils.getNonEmptyMessage(e)
+                reportAuthPosthogEvent(
+                    "refresh token failed", this.javaClass.simpleName, trigger, mapOf(
+                        "error" to errorMessage,
+                        "account.id" to account.id,
+                        "accessTokenHash" to credentials.accessTokenHash(),
+                        "refreshTokenHash" to credentials.refreshTokenHash(),
+                        "expirationDate" to credentials.getExpirationTimeAsDate()
+                    )
+                )
+            }
+
             val authenticationException = ExceptionUtils.findCause(AuthenticationException::class.java, e)
             if (authenticationException != null) {
                 throw e

ide-common/src/main/kotlin/org/digma/intellij/plugin/auth/account/CentralizedLoginHandler.kt

@@ -94,13 +94,16 @@ class CentralizedLoginHandler(analyticsProvider: RestAnalyticsProvider) : Abstra
 
             warnWithException(e, "Exception in loginOrRefresh {}, url {}", e, analyticsProvider.apiUrl)
             ErrorReporter.getInstance().reportError("${javaClass.simpleName}.loginOrRefresh", e, mapOf("loginOrRefresh trigger" to trigger))
-            val errorMessage = ExceptionUtils.getNonEmptyMessage(e)
-            reportAuthPosthogEvent(
-                "loginOrRefresh failed",
-                this.javaClass.simpleName,
-                trigger,
-                mapOf("error" to errorMessage)
-            )
+
+            withAuthManagerDebug {
+                val errorMessage = ExceptionUtils.getNonEmptyMessage(e)
+                reportAuthPosthogEvent(
+                    "loginOrRefresh failed",
+                    this.javaClass.simpleName,
+                    trigger,
+                    mapOf("error" to errorMessage)
+                )
+            }
 
             //if got exception here then we probably can't refresh,logout, user will be redirected to login,
             // throw the exception to report it

ide-common/src/main/kotlin/org/digma/intellij/plugin/auth/account/LocalLoginHandler.kt

@@ -129,13 +129,16 @@ class LocalLoginHandler(analyticsProvider: RestAnalyticsProvider) : AbstractLogi
 
             warnWithException(e, "Exception in loginOrRefresh {}, url {}", e, analyticsProvider.apiUrl)
             ErrorReporter.getInstance().reportError("${javaClass.simpleName}.loginOrRefresh", e, mapOf("loginOrRefresh trigger" to trigger))
-            val errorMessage = ExceptionUtils.getNonEmptyMessage(e)
-            reportAuthPosthogEvent(
-                "loginOrRefresh failed",
-                this.javaClass.simpleName,
-                trigger,
-                mapOf("error" to errorMessage)
-            )
+
+            withAuthManagerDebug {
+                val errorMessage = ExceptionUtils.getNonEmptyMessage(e)
+                reportAuthPosthogEvent(
+                    "loginOrRefresh failed",
+                    this.javaClass.simpleName,
+                    trigger,
+                    mapOf("error" to errorMessage)
+                )
+            }
 
             //if got exception here it may be from refresh or login, in both cases delete the current account
             //and login again

ide-common/src/main/kotlin/org/digma/intellij/plugin/auth/account/LoginHandler.kt

@@ -8,6 +8,7 @@ import org.digma.intellij.plugin.analytics.RestAnalyticsProvider
 import org.digma.intellij.plugin.auth.NoOpLoginHandler
 import org.digma.intellij.plugin.auth.credentials.DigmaCredentials
 import org.digma.intellij.plugin.auth.reportAuthPosthogEvent
+import org.digma.intellij.plugin.auth.withAuthManagerDebug
 import org.digma.intellij.plugin.common.ExceptionUtils
 import org.digma.intellij.plugin.errorreporting.ErrorReporter
 import org.digma.intellij.plugin.log.Log
@@ -112,8 +113,10 @@ interface LoginHandler {
         } catch (e: Throwable) {
             warnWithException(e, "Exception in logout {}, trigger {}", e, trigger)
             ErrorReporter.getInstance().reportError("${javaClass.simpleName}.logout", e, mapOf("logout trigger" to trigger))
-            val errorMessage = ExceptionUtils.getNonEmptyMessage(e)
-            reportAuthPosthogEvent("logout failed", this.javaClass.simpleName, trigger, mapOf("error" to errorMessage))
+            withAuthManagerDebug {
+                val errorMessage = ExceptionUtils.getNonEmptyMessage(e)
+                reportAuthPosthogEvent("logout failed", this.javaClass.simpleName, trigger, mapOf("error" to errorMessage))
+            }
             false
         }
     }