better filter for method instrumentation #53
Description
see
com.digma.otel.javaagent.extension.instrumentation.methods.MethodsInPackageTypeInstrumentation
we need to filter out everything that opentelemtry will instrument.
the list is too long and changing rapidly so this is not really feasible by adding matchers.
currently MethodsInPackageTypeInstrumentation filters out common libraries that we support and that are very common and known to be instrumented by otel.
its only a matter of time until we will produce double spans for some libraries.
we need to find a generic way to not produce double spans.
one way could be to instrument everything, in the advice check if there is already a span for the method and don't start our span. our instrumentation needs to be lowest priority, DigmaMethodsInstrumentationModule#order should be very high number.
I'm not sure its possible and trying to consult otel developers.