Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixup of seconds and milliseconds in cleanup job for in memory session handler #76

Open
andreaswarvsten opened this issue Sep 13, 2022 · 0 comments

Comments

@andreaswarvsten
Copy link

Hi, there looks to be an error in the cleanup method for the InMemorySessionHandler, when we check for an expired TimeOutWrapper. The delay parameter is being passed in seconds, instead of milliseconds. This causes the user to be logged out every time the cleanup job runs, unless they have accessed the TimeOutWrapper 1.8 seconds before (If we go by the default settings).

Class: InMemorySessionHandler.java
Method: cleanup(Map<E, TimeOutWrapper> map, long cleanupDelay, String msg)
-> tow.isExpired(cleanupDelay)

jsotrifork added a commit to trifork/OIOSAML.Java that referenced this issue Jun 13, 2024
jsotrifork added a commit to trifork/OIOSAML.Java that referenced this issue Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant