Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Questio] Regarding Observation and Action Spaces #3

Open
LucasAlegre opened this issue Dec 2, 2024 · 1 comment
Open

[Questio] Regarding Observation and Action Spaces #3

LucasAlegre opened this issue Dec 2, 2024 · 1 comment

Comments

@LucasAlegre
Copy link

Hi @dimichai,

First of all, I really liked this environment, and I believe it is a nice benchmark for MORL algorithms! :)

I was checking the readme and two questions came to my mind:

  1. I noticed the observation does not include the positions which already contain a station. Isn't this information necessary for the agent to infer the optimal policy/optimal q-values? The value of a state depends on whether the agent can still put more stations or not, for example.

  2. Wouldn't it make sense for the agent to choose to not put a station in a cell? Then it could create a line with more spaced stations. This would be easy to change by creating an additional action for putting a station in a cell.

@dimichai
Copy link
Owner

dimichai commented Dec 5, 2024

Hi @LucasAlegre,

Thank you so much for your kind words and insightful comments. I really appreciate the effort!

Addressing your points:

  1. You are absolutely right about the current state representation. It was originally designed with a simpler environment in mind, but it no longer aligns. I am revising it to include both the positions containing stations and the agent’s current location. I'll comment here once I implement it.

  2. This is a great suggestion. However, I think implementing this would require some additional experiments to incorporate the constraints. As it stands, the agent’s movement is restricted by the action mask, but introducing an extra action for station placement would essentially allow for free movement. We might need to adjust how constraints are calculated in that case. So maybe something to look into in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants