Skip to content

Broken HTML in $ting_details; #32

@mikl

Description

@mikl

I was overriding ting-object.tpl.php for alternator, when I ran into some rendering issues. Turns out they are caused by invalid markup from $ting_details;. The output in my example is:

<div class="item-list">
  <div>
    <li title="" class="details clearfix first">
      <div class="item-list">
        <div class="ting-properties">
          <li class="ting-subjects first last">
            <div class="item-list">
              <h3>Emner</h3>
              <span>
                <li class="first last">
                  <a href="/ting/search/%22hip%20hop%22" class="ting-subjects ting-subjects-oss-genre">hip hop</a>
                </li>
            </span>
        </div>
      </li>
  </div>
</div>
</li>
<li title="" class="additional-details clearfix">
  <div class="item-list">
    <div class="ting-properties">
      <li class="ting-contributors first">
        <div class="item-list">
          <h3>Contributors</h3>
          <span>
            <li class="first">Erik Mortvedt</li>
            <li class="last">Kristoffer Tømmerbakke</li>
          </span>
        </div>
      </li>
      <li class="ting-type first">
        <div class="item-list">
          <h3>Type</h3>
          <span>
            <li class="first last">netmusik (album)</li>
          </span>
      </div>
    </li>
    <li class="ting-extent first">
      <div class="item-list">
        <h3>Længde</h3>
        <span>
          <li class="first last">3:01</li>
        </span>
      </div>
    </li>
    <li class="ting-publisher first">
      <div class="item-list">
        <h3>Udgiver</h3>
        <span>
          <li class="first last">Mtg</li>
        </span>
      </div>
    </li>
  </div>
</div>
</li>
<li title="" class="descrition clearfix last">
  <div class="item-list"></div>
</li>
</div></div>

Besides being excessively nested and complex, it also suffers from several cases of unbalanced tags (ie. closing li or div tags we have not opened). This breaks the collapsed container for additional information on the mobile site.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions