Fixed right mouse button bug (#913)

Author: dirkwhoffmann

Emulator/VACore/Components/Agnus/Agnus.cpp

@@ -686,10 +686,10 @@ Agnus::eolHandler()
     pos.eol();
 
     // Update pot counters
-    if (paula.chargeX0 < 1.0) U8_INC(paula.potCntX0, 1);
-    if (paula.chargeY0 < 1.0) U8_INC(paula.potCntY0, 1);
-    if (paula.chargeX1 < 1.0) U8_INC(paula.potCntX1, 1);
-    if (paula.chargeY1 < 1.0) U8_INC(paula.potCntY1, 1);
+    if (paula.chargeX0 < 1.0 || controlPort1.mouse.MMB()) U8_INC(paula.potCntX0, 1);
+    if (paula.chargeY0 < 1.0 || controlPort1.mouse.RMB()) U8_INC(paula.potCntY0, 1);
+    if (paula.chargeX1 < 1.0 || controlPort2.mouse.MMB()) U8_INC(paula.potCntX1, 1);
+    if (paula.chargeY1 < 1.0 || controlPort2.mouse.RMB()) U8_INC(paula.potCntY1, 1);
 
     // Transfer DMA requests from Paula to Agnus
     paula.channel0.requestDMA();

Emulator/VACore/Peripherals/Mouse/Mouse.h

@@ -221,6 +221,11 @@ class Mouse final : public SubComponent {
     i64 getDeltaX();
     i64 getDeltaY();
 
+    // Queries the button state
+    bool LMB() const { return leftButton; }
+    bool MMB() const { return middleButton; }
+    bool RMB() const { return rightButton; }
+
     // Returns the mouse coordinates as they appear in the JOYDAT register
     u16 getXY();
 

GUI/Dialogs/Inspector/Inspector.swift

@@ -682,7 +682,7 @@ class Inspector: DialogController {
 
         // Enter debug mode
         emu.trackOn()
-        amiga.autoInspectionMask = 0xFF
+        amiga.autoInspectionMask = Int.max
 
         // Adjust window height to match what we see in interface builder
         if let window = self.window {

GUI/Dialogs/Media/DiskExporter.swift

@@ -463,18 +463,18 @@ extension DiskExporter: NSFilePromiseProviderDelegate {
 
     func filePromiseProvider(_ filePromiseProvider: NSFilePromiseProvider, fileNameForType fileType: String) -> String {
 
-        var name: String
-        
+        var name = "Untitled" // vol?.name ?? "Untitled"
+
         switch formatPopup.selectedTag() {
 
-        case Format.hdf: name = "Untitled.hdf"
-        case Format.hdz: name = "Untitled.hdz"
-        case Format.adf: name = "Untitled.adf"
-        case Format.adz: name = "Untitled.adz"
-        case Format.ext: name = "Untitled.adf"
-        case Format.img: name = "Untitled.img"
-        case Format.ima: name = "Untitled.ima"
-        case Format.vol: name = "Untitled"
+        case Format.hdf: name += ".hdf"
+        case Format.hdz: name += ".hdz"
+        case Format.adf: name += ".adf"
+        case Format.adz: name += ".adz"
+        case Format.ext: name += ".adf"
+        case Format.img: name += ".img"
+        case Format.ima: name += ".ima"
+        case Format.vol: break
 
         default: fatalError()
         }