Event on Audio Buffer Over/Underflow

[m0ppers]

So I have been experimenting with the results of #879 and the situation is now much better but not entirely fixed for me. This is probably related to my sound setup and it needs more investigation from my side.

However right now I always have to enable AUDBUF_DEBUG to get any idea what is going on. As this generates quite some logspam I would like to have an event when an AudioBuffer Over/Underflow is happening to also get an idea in non-debug builds how often this is happening. Would something like this be possible?

[dirkwhoffmann]

@m0ppers: As you already know, vAmiga sends various messages to the GUI...

enum class Msg : long
{
    ...
    
    // Agnus
    EOL_REACHED,
    EOF_REACHED,
    BEAMTRAP_REACHED,
    BEAMTRAP_UPDATED,
    
    // Copper
    COPPERBP_REACHED,
    COPPERBP_UPDATED,
    COPPERWP_REACHED,
    COPPERWP_UPDATED,
    
    // Denise
    VIEWPORT,
 
    ...
}

I could easily add

    // Audio
    AUDBUF_OVERFLOW,
    AUDBUF_UNDERFLOW,

Would that help?

[m0ppers]

exactly what I am looking for 🥳

[dirkwhoffmann]

Code is on the dev branch, but I need to change it a bit...

void
AudioPort::handleBufferOverflow()
{
    // Reset the write pointer
    stream.alignWritePtr();

    // Determine the number of elapsed seconds since the last adjustment
    auto elapsedTime = util::Time::now() - lastAlignment;
    lastAlignment = util::Time::now();

    // Adjust the sample rate if the emulator runs under normal conditions
    if (emulator.isRunning() && !emulator.isWarping()) {

        stats.bufferOverflows++;
        debug(AUDBUF_DEBUG, "Audio buffer overflow after %f seconds\n", elapsedTime.asSeconds());

        // Adjust the sample rate
        setSampleRate(host.getConfig().sampleRate);
        debug(AUDBUF_DEBUG, "New sample rate = %.2f\n", sampleRate);
    }

    // Inform the GUI
    msgQueue.put(Msg::AUDBUF_OVERFLOW, elapsedTime.asMilliseconds());
}

With the current code, the GUI is flooded with messages in warp mode. I'll better move the msgQueue code inside the if.