refactor modal building to run typeConverter writes even without modal instance

Author: Cenngo

src/Discord.Net.Interactions/Extensions/IDiscordInteractionExtensions.cs

@@ -84,10 +84,8 @@ public static async Task<Modal> ToModalAsync<T>(this IDiscordInteraction interac
                             var inputBuilder = new TextInputBuilder(textComponent.CustomId, textComponent.Style, textComponent.Placeholder, textComponent.IsRequired ? textComponent.MinLength : null,
                             textComponent.MaxLength, textComponent.IsRequired);
 
-                            if (modalInstance != null)
-                            {
-                                await textComponent.TypeConverter.WriteAsync(inputBuilder, interaction, textComponent, textComponent.Getter(modalInstance));
-                            }
+                            var instanceValue = modalInstance is not null ? textComponent.Getter(modalInstance) : null;
+                            await textComponent.TypeConverter.WriteAsync(inputBuilder, interaction, textComponent, instanceValue);
 
                             var labelBuilder = new LabelBuilder(textComponent.Label, inputBuilder, textComponent.Description);
                             builder.AddLabel(labelBuilder);
@@ -97,10 +95,8 @@ public static async Task<Modal> ToModalAsync<T>(this IDiscordInteraction interac
                         {
                             var inputBuilder = new SelectMenuBuilder(selectMenuComponent.CustomId, selectMenuComponent.Options.Select(x => new SelectMenuOptionBuilder(x)).ToList(), selectMenuComponent.Placeholder, selectMenuComponent.MaxValues, selectMenuComponent.MinValues, false, isRequired: selectMenuComponent.IsRequired);
 
-                            if (modalInstance != null)
-                            {
-                                await selectMenuComponent.TypeConverter.WriteAsync(inputBuilder, interaction, selectMenuComponent, selectMenuComponent.Getter(modalInstance));
-                            }
+                            var instanceValue = modalInstance is not null ? selectMenuComponent.Getter(modalInstance) : null;
+                            await selectMenuComponent.TypeConverter.WriteAsync(inputBuilder, interaction, selectMenuComponent, instanceValue);
 
                             var labelBuilder = new LabelBuilder(selectMenuComponent.Label, inputBuilder, selectMenuComponent.Description);
                             builder.AddLabel(labelBuilder);
@@ -111,10 +107,8 @@ public static async Task<Modal> ToModalAsync<T>(this IDiscordInteraction interac
                             var channelTypes = snowflakeSelectComponent is ChannelSelectComponentInfo channelSelectComponent ? channelSelectComponent.ChannelTypes : null;
                             var inputBuilder = new SelectMenuBuilder(snowflakeSelectComponent.CustomId, null, snowflakeSelectComponent.Placeholder, snowflakeSelectComponent.MaxValues, snowflakeSelectComponent.MinValues, false, snowflakeSelectComponent.ComponentType, [..channelTypes], snowflakeSelectComponent.DefaultValues.ToList(), null, snowflakeSelectComponent.IsRequired);
 
-                            if (modalInstance != null)
-                            {
-                                await snowflakeSelectComponent.TypeConverter.WriteAsync(inputBuilder, interaction, snowflakeSelectComponent, snowflakeSelectComponent.Getter(modalInstance));
-                            }
+                            var instanceValue = modalInstance is not null ? snowflakeSelectComponent.Getter(modalInstance) : null;
+                            await snowflakeSelectComponent.TypeConverter.WriteAsync(inputBuilder, interaction, snowflakeSelectComponent, instanceValue);
 
                             var labelBuilder = new LabelBuilder(snowflakeSelectComponent.Label, inputBuilder, snowflakeSelectComponent.Description);
                             builder.AddLabel(labelBuilder);
@@ -124,21 +118,20 @@ public static async Task<Modal> ToModalAsync<T>(this IDiscordInteraction interac
                         {
                             var inputBuilder = new FileUploadComponentBuilder(fileUploadComponent.CustomId, fileUploadComponent.MinValues, fileUploadComponent.MaxValues, fileUploadComponent.IsRequired);
 
-                            if (modalInstance != null)
-                            {
-                                await fileUploadComponent.TypeConverter.WriteAsync(inputBuilder, interaction, fileUploadComponent, fileUploadComponent.Getter(modalInstance));
-                            }
+                            var instanceValue = modalInstance is not null ? fileUploadComponent.Getter(modalInstance) : null;
+                            await fileUploadComponent.TypeConverter.WriteAsync(inputBuilder, interaction, fileUploadComponent, instanceValue);
 
                             var labelBuilder = new LabelBuilder(fileUploadComponent.Label, inputBuilder, fileUploadComponent.Description);
                             builder.AddLabel(labelBuilder);
                         }
                         break;
                     case TextDisplayComponentInfo textDisplayComponent:
-                    {
-                        var instanceValue = modalInstance is not null ? textDisplayComponent.Getter(modalInstance).ToString() : null;
-                        var content = instanceValue ?? (textDisplayComponent.DefaultValue as string) ?? textDisplayComponent.Content;
-                        var componentBuilder = new TextDisplayBuilder(content);
-                        builder.AddTextDisplay(componentBuilder);
+                        {
+                            var instanceValue = modalInstance is not null ? textDisplayComponent.Getter(modalInstance).ToString() : null;
+                            var content = instanceValue ?? (textDisplayComponent.DefaultValue as string) ?? textDisplayComponent.Content;
+
+                            var componentBuilder = new TextDisplayBuilder(content);
+                            builder.AddTextDisplay(componentBuilder);
                         }
                         break;
                     default: