Skip to content

Commit 5ca29fd

Browse files
Misha-133d4n3436
andauthored
Remove unsupported SDK targets (#3193)
* yee old sdks (and CI cache too since it's pretty useless) * also bump deps * Update src/Discord.Net.Interactions/Discord.Net.Interactions.csproj Co-authored-by: d4n <[email protected]> * Update src/Discord.Net.Core/Discord.Net.Core.csproj Co-authored-by: d4n <[email protected]> * `.ForEachAsync` => `await foreach` * remove old targets from .nuspec & update docs * bump sdk in ws4net provider (probably should deprecate it tho) --------- Co-authored-by: d4n <[email protected]>
1 parent a468e18 commit 5ca29fd

File tree

41 files changed

+60
-4383
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+60
-4383
lines changed

.github/workflows/dotnet.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ jobs:
2626
uses: actions/setup-dotnet@v4
2727
with:
2828
dotnet-version: 9.0.x
29-
cache: true
30-
cache-dependency-path: "**/packages.lock.json"
3129

3230
- name: Is Tag Build
3331
if: startsWith(github.ref, 'refs/tags/')

Discord.Net.targets

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
<NoWarn>$(NoWarn);CS1573;CS1591</NoWarn>
2929
<WarningsAsErrors>true</WarningsAsErrors>
3030
<GenerateDocumentationFile>true</GenerateDocumentationFile>
31-
<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
3231
</PropertyGroup>
3332
<ItemGroup>
3433
<None Include="../../docs/marketing/logo/PackageLogo.png" Pack="true" PackagePath=""/>

NUGET_README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ alternatively, you may choose to install the
7070

7171
Discord supports only TLS1.2+ on all their websites including the API since 07/19/2022.
7272
.NET Framework does not support this protocol by default.
73-
If you depend on .NET Framework, it is suggested to upgrade your project to `net6-windows`.
73+
If you depend on .NET Framework, it is suggested to upgrade your project to `net8-windows`.
7474
This framework supports most of the windows-only features introduced by fx, and resolves startup errors from the TLS protocol mismatch.
7575

7676
## 🗃️ Versioning Guarantees

docs/guides/breakings/v3.19.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
uid: Guides.Breakings.V3_19
3+
title: V3.19
4+
---
5+
6+
# V3.19
7+
This release moves Discord.NET to the modern .NET sdk versions, dropping support for .NET Framework and older .NET versions, prior to .NET 8.

docs/guides/getting_started/installing.md

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,24 +10,15 @@ recommended way for you to install this library. Alternatively, you
1010
may also compile this library yourself should you so desire.
1111

1212
## Supported Platforms
13-
14-
Discord.Net targets [.NET 6.0] and [.NET 5.0], but is also available on older versions, like [.NET Standard] and [.NET Core]; this still means
15-
that creating applications using the latest version of .NET (6.0)
16-
is most recommended. If you are bound by Windows-specific APIs or
17-
other limitations, you may also consider targeting [.NET Framework]
18-
4.6.1 or higher.
13+
Discord.Net targets [.NET 8.0] and [.NET 9.0].
1914

2015
> [!WARNING]
2116
> Using this library with [Mono] is not supported until further
2217
> notice. It is known to have issues with the library's WebSockets
2318
> implementation and may crash the application upon startup.
2419
25-
[mono]: https://www.mono-project.com/
26-
[.net 6.0]: https://docs.microsoft.com/en-us/dotnet/core/whats-new/dotnet-6
27-
[.net 5.0]: https://docs.microsoft.com/en-us/dotnet/core/whats-new/dotnet-5
28-
[.net standard]: https://docs.microsoft.com/en-us/dotnet/articles/standard/library
29-
[.net core]: https://docs.microsoft.com/en-us/dotnet/articles/core/
30-
[.net framework]: https://docs.microsoft.com/en-us/dotnet/framework/get-started/
20+
[.net 9.0]: https://docs.microsoft.com/en-us/dotnet/core/whats-new/dotnet-9
21+
[.net 8.0]: https://docs.microsoft.com/en-us/dotnet/core/whats-new/dotnet-8
3122
[additional steps]: #installing-on-net-standard-11
3223

3324
## Installing
@@ -100,15 +91,15 @@ In order to compile Discord.Net, you will need the following:
10091

10192
### Using Visual Studio
10293

103-
- [Visual Studio 2019](https://visualstudio.microsoft.com/) or later.
104-
- [.NET 5 SDK]
94+
- [Visual Studio 2022](https://visualstudio.microsoft.com/) or later.
95+
- [.NET 9 SDK]
10596

106-
The .NET 5 workload is required during Visual Studio
97+
The .NET 8 workload is required during Visual Studio
10798
installation.
10899

109100
### Using Command Line
110101

111-
* [.NET 5 SDK]
102+
* [.NET 9 SDK]
112103

113104
## Additional Information
114105

@@ -151,4 +142,4 @@ by installing one or more custom packages as listed below.
151142

152143
---
153144

154-
[.NET 5 SDK]: https://dotnet.microsoft.com/download
145+
[.NET 9 SDK]: https://dotnet.microsoft.com/download

docs/guides/getting_started/samples/project.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77

88
<PropertyGroup>
99
<OutputType>Exe</OutputType>
10-
<TargetFramework>net6.0</TargetFramework>
10+
<TargetFramework>net9.0</TargetFramework>
1111
</PropertyGroup>
1212

1313
<ItemGroup>
14-
<PackageReference Include="Discord.Net" Version="3.13.0" />
14+
<PackageReference Include="Discord.Net" Version="3.18.0" />
1515
</ItemGroup>
1616

1717
</Project>

docs/guides/toc.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
topicUid: Guides.Breakings.V2V3Guide
77
- name: V3.18
88
topicUid: Guides.Breakings.V3_18
9+
- name: V3.19
10+
topicUid: Guides.Breakings.V3_19
911
- name: Getting Started
1012
items:
1113
- name: Installation

experiment/Discord.Net.BuildOverrides/Discord.Net.BuildOverrides.csproj

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,7 @@
1313
</PropertyGroup>
1414

1515
<ItemGroup>
16-
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
17-
</ItemGroup>
18-
19-
<ItemGroup Condition=" '$(TargetFramework)' == 'net461' ">
20-
<Reference Include="System.Net.Http" />
16+
<PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
2117
</ItemGroup>
2218

2319
</Project>

experiment/Discord.Net.BuildOverrides/packages.lock.json

Lines changed: 0 additions & 21 deletions
This file was deleted.

samples/BasicBot/packages.lock.json

Lines changed: 0 additions & 72 deletions
This file was deleted.

0 commit comments

Comments
 (0)