docs: fix audit event type examples in documentation

Update event type examples in AuditEventEnvelope docstring and test
fixtures to match actual implementation using underscore notation
instead of dot notation.

- Change 'access_request.created' to 'access_create'
- Change 'group.member_added' to 'group_member_added'
- Update test fixture to use realistic event type names

This ensures plugin developers see accurate examples that match the
actual event types emitted by operations throughout the codebase.

Signed-off-by: Jean-Philippe Lachance <[email protected]>

Author: JPLachance

api/plugins/audit_events.py

@@ -33,7 +33,7 @@ class AuditEventEnvelope:
 
     Attributes:
         id: Unique event identifier (UUID v4) for deduplication across retries
-        event_type: Access event type (e.g., 'access_request.created', 'group.member_added')
+        event_type: Access event type (e.g., 'access_create', 'group_member_added')
         timestamp: When the audited action occurred (timezone-aware UTC datetime)
         actor_id: WHO - User ID of the person performing the action
         actor_email: WHO - Email of the actor for human traceability

tests/test_audit_events.py

@@ -13,7 +13,7 @@ def sample_envelope() -> AuditEventEnvelope:
     """Create a sample audit event envelope for testing."""
     return AuditEventEnvelope(
         id=uuid4(),
-        event_type="access_request.created",
+        event_type="access_create",
         timestamp=datetime.now(timezone.utc),
         actor_id="user-123",
         actor_email="[email protected]",
@@ -32,7 +32,7 @@ class TestAuditEventEnvelope:
 
     def test_envelope_creation(self, sample_envelope: AuditEventEnvelope) -> None:
         """Test AuditEventEnvelope can be instantiated with all required fields."""
-        assert sample_envelope.event_type == "access_request.created"
+        assert sample_envelope.event_type == "access_create"
         assert sample_envelope.actor_id == "user-123"
         assert sample_envelope.actor_email == "[email protected]"
         assert sample_envelope.target_type == "access_request"