Skip to content

Wrong handling empty overwrites in permissionsLocked #11190

@vakiliner

Description

@vakiliner

// Handle empty overwrite
if (
(!channelVal &&
parentVal.deny.bitfield === PermissionsBitField.DefaultBit &&
parentVal.allow.bitfield === PermissionsBitField.DefaultBit) ||
(!parentVal &&
channelVal.deny.bitfield === PermissionsBitField.DefaultBit &&
channelVal.allow.bitfield === PermissionsBitField.DefaultBit)
) {
return true;
}

Not all empty permission overwrites need to be excluded
Only @everyone needs to be excluded

What I did

  1. Create a category and a text channel in it
  2. Add an empty overwrite for the user to the category or channel
  3. Check permissionsLocked

Expected - false, but received - true

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions