Skip to content

fix(Client): Move client initialization code #11184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+7 −10
Open

fix(Client): Move client initialization code #11184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c16942f
Update index.js
vakiliner Oct 16, 2025
ce7facb
Fix
vakiliner Oct 16, 2025
382f331
Fix path to ClientUser
vakiliner Oct 16, 2025
3b16e5f
Update Client.js
vakiliner Oct 16, 2025
117893b
Merge branch 'main' into patch-1
vakiliner Oct 16, 2025
4ab11b1
Migrating back to READY.js
vakiliner Oct 19, 2025
a4c0a24
Move _checkReady()
vakiliner Oct 19, 2025
61a4a0d
Merge branch 'main' into patch-1
Jiralite Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions packages/discord.js/src/client/Client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,15 +346,6 @@ class Client extends BaseClient {
);
this.ws.on(WebSocketShardEvents.Dispatch, this._handlePacket.bind(this));

this.ws.on(WebSocketShardEvents.Ready, async data => {
for (const guild of data.guilds) {
this.expectedGuilds.add(guild.id);
}

this.status = Status.WaitingForGuilds;
await this._checkReady();
});

this.ws.on(WebSocketShardEvents.HeartbeatComplete, ({ heartbeatAt, latency }, shardId) => {
this.emit(Events.Debug, `[WS => Shard ${shardId}] Heartbeat acknowledged, latency of ${latency}ms.`);
this.lastPingTimestamps.set(shardId, heartbeatAt);
Expand Down Expand Up @@ -384,7 +375,9 @@ class Client extends BaseClient {
PacketHandlers[packet.t](this, packet, shardId);
}

if (this.status === Status.WaitingForGuilds && WaitingForGuildEvents.includes(packet.t)) {
if (packet.t === GatewayDispatchEvents.Ready) {
await this._checkReady();
} else if (this.status === Status.WaitingForGuilds && WaitingForGuildEvents.includes(packet.t)) {
this.expectedGuilds.delete(packet.d.id);
await this._checkReady();
}
Expand Down
4 changes: 4 additions & 0 deletions packages/discord.js/src/client/websocket/handlers/READY.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

const { ClientApplication } = require('../../../structures/ClientApplication.js');
const { Status } = require('../../../util/Status.js');

let ClientUser;

Expand All @@ -14,6 +15,7 @@ module.exports = (client, { d: data }, shardId) => {
}

for (const guild of data.guilds) {
client.expectedGuilds.add(guild.id);
guild.shardId = shardId;
client.guilds._add(guild);
}
Expand All @@ -23,4 +25,6 @@ module.exports = (client, { d: data }, shardId) => {
} else {
client.application = new ClientApplication(client, data.application);
}

client.status = Status.WaitingForGuilds;
};