Skip to content

fix(GuildChannel): Handle empty overwrite must only handle @everyone #11221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(GuildChannel): Handle empty overwrite must only handle @everyone #11221

wants to merge 5 commits into from

Conversation

@vakiliner
Copy link
Contributor

@vakiliner vakiliner commented Oct 27, 2025

Please describe the changes this PR makes and why it should be merged:

In commit 6df3623, handling of empty permission overwrites was added, but it was not taken into account that only @everyone should be handled
Closes #11190

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Oct 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Oct 27, 2025 4:13pm
discord-js-guide Ignored Ignored Preview Oct 27, 2025 4:13pm

@vakiliner vakiliner mentioned this pull request Oct 27, 2025
Closed
@vakiliner vakiliner marked this pull request as ready for review October 27, 2025 18:35
@vakiliner vakiliner requested a review from a team as a code owner October 27, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qjuh Qjuh Qjuh approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

At least 3 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

packages:discord.js

Projects

discord.js
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong handling empty overwrites in permissionsLocked

2 participants

@vakiliner @Qjuh