Skip to content

feat(builders): multipart form data output support #11248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(builders): multipart form data output support #11248

wants to merge 5 commits into from

Conversation

@didinele
Copy link
Member

@didinele didinele commented Nov 5, 2025 •
edited
Loading

No description provided.

@vercel
Copy link

vercel bot commented Nov 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Nov 12, 2025 10:26am
discord-js-guide Ignored Ignored Preview Nov 12, 2025 10:26am

@codecov
Copy link

codecov bot commented Nov 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 85.29412% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.77%. Comparing base (b026d0e) to head (980f46b).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
packages/util/src/encodables.ts 40.00% 6 Missing ⚠️
packages/builders/src/messages/Attachment.ts 86.20% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11248      +/-   ##
==========================================
+ Coverage   44.39%   44.77%   +0.38%     
==========================================
  Files         315      317       +2     
  Lines       18136    18252     +116     
  Branches     1805     1863      +58     
==========================================
+ Hits         8051     8172     +121     
+ Misses      10073    10068       -5     
  Partials       12       12
Flag Coverage Δ
builders 81.09% <92.98%> (+1.35%) ⬆️
core 0.88% <ø> (-0.03%) ⬇️
proxy 65.88% <ø> (ø)
rest 89.26% <ø> (+1.70%) ⬆️
util 41.66% <45.45%> (-1.62%) ⬇️
ws 36.38% <ø> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@didinele didinele marked this pull request as ready for review November 10, 2025 13:07
@didinele didinele requested review from a team as code owners November 10, 2025 13:07
Qjuh
Qjuh requested changes Nov 10, 2025
View reviewed changes
packages/builders/src/messages/Message.ts Outdated
*/
export class MessageBuilder implements JSONEncodable<RESTPostAPIChannelMessageJSONBody> {
export class MessageBuilder
implements JSONEncodable<RESTPostAPIChannelMessageJSONBody>, FileBodyEncodeable<RESTPostAPIChannelMessageJSONBody>
Copy link
Member

@Qjuh Qjuh Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
implements JSONEncodable<RESTPostAPIChannelMessageJSONBody>, FileBodyEncodeable<RESTPostAPIChannelMessageJSONBody>
implements FileBodyEncodeable<RESTPostAPIChannelMessageJSONBody>

This is redundant considering FileBodyEncodeable extends JSONEncodable

Copy link
Member Author

@didinele didinele Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware, but I'm honestly for leaving it in just for extra readability without knowing what a FileBodyEncodeable is (arguably beneficial for docs too?). Thoughts @vladfrangu

Copy link
Member

@Qjuh Qjuh Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For docs it would (should) show the toJSON() on the extended interface already, so not sure of the benefit

@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Nov 10, 2025
@didinele didinele mentioned this pull request Nov 12, 2025
Open
@Jiralite Jiralite added this to the builders 2.0.0 milestone Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qjuh Qjuh Qjuh approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/util

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/util

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/util

@Jiralite Jiralite Awaiting requested review from Jiralite Jiralite is a code owner automatically assigned from discordjs/util

@almeidx almeidx Awaiting requested review from almeidx almeidx is a code owner automatically assigned from discordjs/util

@sdanialraza sdanialraza Awaiting requested review from sdanialraza sdanialraza is a code owner automatically assigned from discordjs/util

@ckohen ckohen Awaiting requested review from ckohen ckohen is a code owner automatically assigned from discordjs/rest

At least 3 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

packages:builders packages:rest packages:util semver:minor

Projects

discord.js
Status: Review in Progress

Milestone

builders 2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@didinele @Qjuh @Jiralite