feat(GuildMemberManager): handle gateway request ratelimit #11253
+46
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didinele
requested review from
SpaceEEC,
iCrawl,
kyranet and
vladfrangu
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v14 #11253 +/- ##
=======================================
Coverage 36.98% 36.98%
=======================================
Files 242 242
Lines 14847 14847
Branches 1368 1368
=======================================
Hits 5491 5491
Misses 9312 9312
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vladfrangu
reviewed
Nov 11, 2025
Comment on lines
+246
to
+249
| this.client.removeListener(Events.GuildMembersChunk, handler); | ||
| this.client.decrementMaxListeners(); | ||
| this.client.removeListener(Events.Raw, rateLimitHandler); | ||
| this.client.decrementMaxListeners(); |
Member
There was a problem hiding this comment.
make this a function pleasee
Member
Author
|
Waiting on #11252 so we know for sure what our approach is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #11252