Skip to content

feat: use native node typescript #11259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: use native node typescript #11259

wants to merge 1 commit into from
+402 −106

Conversation

@almeidx
Copy link
Member

@almeidx almeidx commented Nov 8, 2025 •
edited
Loading

  • Adapted the TypeScript template for native ts support on Node.js
  • Added the templates to the pnpm-workspace on this repository, to ease dependency management
    • This means the templates had to have unique and valid names, so I had to refactor the logic on the package a bit
  • Removed tamasfe.even-better-toml from the recommended dependencies, because it seems completely random?
  • Added pnpm-lock.yaml to .prettierignore

Depends on:

@almeidx almeidx requested review from a team and iCrawl as code owners November 8, 2025 22:51
@almeidx almeidx requested review from SpaceEEC and kyranet November 8, 2025 22:51
@vercel
Copy link

vercel bot commented Nov 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Nov 12, 2025 10:23am
discord-js-guide Ignored Ignored Preview Nov 12, 2025 10:23am

@almeidx almeidx force-pushed the feat/use-node-typescript branch 2 times, most recently from 4b42f76 to c2baa37 Compare November 8, 2025 23:06
@almeidx almeidx marked this pull request as draft November 8, 2025 23:14
vladfrangu
vladfrangu reviewed Nov 9, 2025
View reviewed changes
Qjuh
Qjuh reviewed Nov 12, 2025
View reviewed changes
@almeidx almeidx force-pushed the feat/use-node-typescript branch from c2baa37 to 37799b4 Compare November 12, 2025 10:14
@almeidx almeidx marked this pull request as ready for review November 12, 2025 10:18
@almeidx almeidx force-pushed the feat/use-node-typescript branch from 37799b4 to 8a726ca Compare November 12, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladfrangu vladfrangu vladfrangu left review comments

@Qjuh Qjuh Qjuh approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner

@monbrey monbrey Awaiting requested review from monbrey monbrey is a code owner automatically assigned from discordjs/guide

@almostSouji almostSouji Awaiting requested review from almostSouji almostSouji is a code owner automatically assigned from discordjs/guide

@Jiralite Jiralite Awaiting requested review from Jiralite Jiralite is a code owner automatically assigned from discordjs/guide

@sdanialraza sdanialraza Awaiting requested review from sdanialraza sdanialraza is a code owner automatically assigned from discordjs/guide

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

At least 3 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

packages:create-discord-bot

Projects

discord.js
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@almeidx @vladfrangu @Qjuh