refactor(Webhooks)!: remove WebhookClient #11266
Merged
+32
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: WebhookClient has been removed, use @discordjs/core instead or fetch webhooks. Alternative solutions are in the works
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Jiralite
approved these changes
Nov 10, 2025
vladfrangu
approved these changes
Nov 11, 2025
didinele
approved these changes
Nov 11, 2025
TAEMBO
reviewed
Nov 12, 2025
Contributor
TAEMBO
left a comment
TAEMBO
left a comment
There was a problem hiding this comment.
Worth removing BaseClient as well imo due to Client being the only other thing using it
Member
Author
|
I decided not to unify the client class in this PR. I think we should in a PR following this one though. |
Qjuh
reviewed
Nov 12, 2025
BREAKING CHANGE: `WebhookURLInvalid` is no longer an error code (obsolete).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: WebhookClient has been removed, use @discordjs/core instead or fetch webhooks. Alternative solutions are in the works
Please describe the changes this PR makes and why it should be merged:
WebhookClient is an incredibly inefficient way to interact with webhooks (creates a rest instance per webhook, an entire client per webhook etc..). We are working on developing an alternative to this that will mimic the simplicity of WebhookClient. In the meantime, we recommend using @discordjs/core if you are not connected to gateway, and fetching webhooks from the client if you are. We know making an extra API call is not ideal, the alternative will solve this and will land as soon as we finish internal discussions.
Closes: #8733
Status and versioning classification: