Add frozen string literal to all the files (#405)

Author: arpitjalan

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in onebox.gemspec

Guardfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 guard :rspec, cmd: 'bundle exec rspec' do
   watch(%r{^spec/.+_spec\.rb$})
   watch(%r{^lib/(.+)\.rb$})               { |m| "spec/lib/#{m[1]}_spec.rb" }

Rakefile

@@ -1,4 +1,6 @@
 #!/usr/bin/env rake
+# frozen_string_literal: true
+
 require "rspec/core/rake_task"
 require 'bundler'
 

lib/onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "openssl"
 require "open-uri"
 require "multi_json"

lib/onebox/engine.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     def self.included(object)

lib/onebox/engine/amazon_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require "onebox/open_graph"
 

lib/onebox/engine/asciinema_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class AsciinemaOnebox

lib/onebox/engine/audio_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class AudioOnebox

lib/onebox/engine/audioboom_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class AudioboomOnebox

lib/onebox/engine/bandcamp_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class BandCampOnebox

lib/onebox/engine/cloudapp_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class CloudAppOnebox

lib/onebox/engine/coub_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class CoubOnebox

lib/onebox/engine/douban_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class DoubanOnebox

lib/onebox/engine/five_hundred_px_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class FiveHundredPxOnebox

lib/onebox/engine/flickr_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative './opengraph_image'
 
 module Onebox

lib/onebox/engine/flickr_shortened_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative './opengraph_image'
 
 module Onebox

lib/onebox/engine/gfycat_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class GfycatOnebox

lib/onebox/engine/giphy_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class GiphyOnebox

lib/onebox/engine/github_blob_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../mixins/git_blob_onebox'
 
 module Onebox

lib/onebox/engine/github_commit_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class GithubCommitOnebox

lib/onebox/engine/github_gist_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class GithubGistOnebox

lib/onebox/engine/github_issue_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class GithubIssueOnebox

lib/onebox/engine/github_pullrequest_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class GithubPullRequestOnebox

lib/onebox/engine/gitlab_blob_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../mixins/git_blob_onebox'
 
 module Onebox

lib/onebox/engine/google_calendar_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class GoogleCalendarOnebox

lib/onebox/engine/google_docs_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class GoogleDocsOnebox

lib/onebox/engine/google_drive_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class GoogleDriveOnebox

lib/onebox/engine/google_maps_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class GoogleMapsOnebox

lib/onebox/engine/google_photos_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class GooglePhotosOnebox

lib/onebox/engine/google_play_app_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class GooglePlayAppOnebox

lib/onebox/engine/html.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     module HTML

lib/onebox/engine/image_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class ImageOnebox

lib/onebox/engine/imgur_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class ImgurOnebox

lib/onebox/engine/instagram_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'htmlentities'
 
 module Onebox

lib/onebox/engine/json.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     module JSON

lib/onebox/engine/kaltura_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class KalturaOnebox

lib/onebox/engine/mixcloud_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class MixcloudOnebox

lib/onebox/engine/opengraph_image.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     module OpengraphImage

lib/onebox/engine/pastebin_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class PastebinOnebox

lib/onebox/engine/pdf_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class PdfOnebox

lib/onebox/engine/pubmed_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class PubmedOnebox

lib/onebox/engine/reddit_image_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class RedditImageOnebox

lib/onebox/engine/replit_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class ReplitOnebox

lib/onebox/engine/simplecast_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class SimplecastOnebox

lib/onebox/engine/sketchfab_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class SketchFabOnebox

lib/onebox/engine/slides_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class SlidesOnebox

lib/onebox/engine/soundcloud_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class SoundCloudOnebox

lib/onebox/engine/stack_exchange_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class StackExchangeOnebox

lib/onebox/engine/standard_embed.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "cgi"
 require "onebox/open_graph"
 

lib/onebox/engine/steam_store_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class SteamStoreOnebox

lib/onebox/engine/trello_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class TrelloOnebox

lib/onebox/engine/twitch_clips_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../mixins/twitch_onebox'
 
 class Onebox::Engine::TwitchClipsOnebox

lib/onebox/engine/twitch_stream_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../mixins/twitch_onebox'
 
 class Onebox::Engine::TwitchStreamOnebox

lib/onebox/engine/twitch_video_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../mixins/twitch_onebox'
 
 class Onebox::Engine::TwitchVideoOnebox

lib/onebox/engine/twitter_status_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class TwitterStatusOnebox

lib/onebox/engine/typeform_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class TypeformOnebox

lib/onebox/engine/video_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class VideoOnebox

lib/onebox/engine/vimeo_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class VimeoOnebox

lib/onebox/engine/wechat_mp_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class WechatMpOnebox

lib/onebox/engine/whitelisted_generic_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'htmlentities'
 
 module Onebox
@@ -255,7 +257,9 @@ def data
       def rewrite_https(html)
         return unless html
         uri = URI(@url)
-        html.gsub!("http://", "https://") if WhitelistedGenericOnebox.host_matches(uri, WhitelistedGenericOnebox.rewrites)
+        if WhitelistedGenericOnebox.host_matches(uri, WhitelistedGenericOnebox.rewrites)
+          html = html.gsub("http://", "https://")
+        end
         html
       end
 

lib/onebox/engine/wikimedia_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class WikimediaOnebox

lib/onebox/engine/wikipedia_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class WikipediaOnebox
@@ -63,7 +65,7 @@ def data
             end
 
             paragraph.gsub!(/\[\d+\]/mi, "")
-            text << paragraph
+            text += paragraph
             cnt += 1
           end
         end

lib/onebox/engine/wistia_onebox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Onebox
   module Engine
     class WistiaOnebox