Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dlang-bot is hitting a lot of 404's lately #195

Open
wilzbach opened this issue Mar 28, 2018 · 2 comments
Open

dlang-bot is hitting a lot of 404's lately #195

wilzbach opened this issue Mar 28, 2018 · 2 comments

Comments

@wilzbach
Copy link
Member

[github/pull_request](dlang/phobos#6370): action=opened
GET https://api.github.com/repos/dlang/phobos/pulls/6370/commits failed; Not Found 404.

Maybe dlang-bot is too fast and it just needs to wait a bit before responding to GH?

@MartinNowak
Copy link
Member

Assuming that this breaks dlang-bot functionality. Quite sloppy of github to not persist all data before sending off hooks. Can we confirm that this is an actual GH issue and that waiting would help?
Maybe we need some kind of a job queue that allows retry on temporary failures, though 404 is a bit tricky.

@wilzbach
Copy link
Member Author

wilzbach commented Apr 6, 2018

Can we confirm that this is an actual GH issue and that waiting would help?

I haven't looked into the logs lately, so I can't really confirm, but it doesn't appear all to often so the only explanation for these rare 404 is that GitHub uses some CDN or distributed database (maybe mongo :P) that doesn't support full consistency.

Maybe we need some kind of a job queue that allows retry on temporary failures, though 404 is a bit tricky.

We also sometimes get 401s when the API limit is exhausted, so a queue might help there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants