From dea2a3bbbdde5426a3be3f28ad265ec9ffd90c0c Mon Sep 17 00:00:00 2001
From: Donald Gray <donald.gray@digirati.com>
Date: Fri, 19 Jan 2024 14:50:30 +0000
Subject: [PATCH] Always close window when role-provisioning

---
 .../IIIFAuth2.API/Features/Access/AccessController.cs      | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/IIIFAuth2/IIIFAuth2.API/Features/Access/AccessController.cs b/src/IIIFAuth2/IIIFAuth2.API/Features/Access/AccessController.cs
index 0be1a8a..05fd6fe 100644
--- a/src/IIIFAuth2/IIIFAuth2.API/Features/Access/AccessController.cs
+++ b/src/IIIFAuth2/IIIFAuth2.API/Features/Access/AccessController.cs
@@ -115,12 +115,15 @@ private async Task<IActionResult> RoleProvisionResponseConverter(IRequest<Handle
                 return View("CloseWindow");
             }
             
+            // Below here are errors but rather than return a 500, return the closeWindow view. This will allow the
+            // viewer to continue (and fail) the auth flow.
             if (provisionRoleResponse.IsError)
             {
-                return StatusCode(provisionRoleResponse.ErrorStatus ?? 500, provisionRoleResponse.ErrorMessage);
+                return View("CloseWindow");
             }
 
-            return StatusCode(500, "Unexpected error encountered");
+            Logger.LogWarning("RoleProvisionResponseConverter could not determine appropriate response");
+            return View("CloseWindow");
         });
     }
 }
\ No newline at end of file