-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Influence of the binning #10
Comments
Hi Sofya, It's been a while since I developed this library, but as far as I remember, most of the code is very similar to Grossfield's. There shouldn't be a significant difference in the results if used on the same dataset. I wonder if the wavy lines might be a result from insufficient samples in the individual bins. If you increase the number of bins, the bin width gets smaller, and therefore less samples are in each bin. If the count per bin approaches 0, the algorithm becomes unstable. What leads me to this suspicion is that the global minimum (where we can expect a higher sample count) seems less wavy overall. Could you check the number of samples in the individual bins? Also, from the plots its not entirely clear to me what I am looking at:
Cheers, |
Hi, thank you for the answer.
Best regards, |
Dear Daniel,
Thank you for implementing the WHAM; I found it very convenient. However, I have an issue with the influence of binning on the shape of the PMF. I've attached the figures with PMFs obtained for the same dataset with the Grossfield and your WHAM programs with different numbers of bins. In the Grossfield implementation, with several bins bigger than 100, PMF becomes relatively smooth and remains the same with increased binning. The two other figures show PMFs with your WHAM (SDs are not shown; these are the free energy values themselves). Relatively smooth PMF is obtained with the smallest number of bins=30, while with an increase in the number of bins, the PMF becomes more and more wavy. What do you think could be done about this?
Thank you,
Sofya
The text was updated successfully, but these errors were encountered: