Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standarize domain names for addons to not use a subdomain of a project domain name #56

Closed
frederickjh opened this issue Mar 6, 2020 · 4 comments · Fixed by #57
Closed

Standarize domain names for addons to not use a subdomain of a project domain name #56

frederickjh opened this issue Mar 6, 2020 · 4 comments · Fixed by #57

Comments

@frederickjh
Copy link
Contributor

frederickjh commented Mar 6, 2020 •
edited
Loading

Some addons use a subdomain of the ${VIRTUAL_HOST}, but if you are using a LetsEncrypt Wildcard domain for your Docksal projects it is only good for one level of subdomain not two.

ie. LetsEncrypt wildcard domain certificate is for *.dev.example.com, so it would be valid for the projects listed below but not for Docksal addons that use a domain name that is a subdomain of a subdomain of dev.example.com

Projects are at:

  • project.dev.example.com
  • project2.dev.example.com
    etc.

Not valid with wildcard certificate:

  • webmail.project.dev.example.com
  • adminer.project.dev.example.com
    etc.

If a dash is used instead of a period a subdomain is used that is valid for the wildcard certificate.

Valid with wildcard certificate:

  • webmail-project.dev.example.com
  • adminer-project.dev.example.com

I believe I suggested using a dash instead of a period for the IDE and it is configured so.

  • ide-project.dev.example.com
    See Enabling IDE in the documentation.

I know that the following addons need this change:

  • Adminer Pull request submitted.
  • Mailhog Already in code.
    Others may need it too but I do not use all of them.
@frederickjh frederickjh changed the title Standarize domain names for addons to not use a subdomain of ${VIRTUAL_HOST} Standarize domain names for addons to not use a subdomain of a project domain name Mar 6, 2020
frederickjh added a commit to frederickjh/addons that referenced this issue Mar 6, 2020
@frederickjh
Fixes docksal#56 for the adminer addon.
d2bc4ec
frederickjh added a commit to frederickjh/addons that referenced this issue Mar 6, 2020
@frederickjh
Fixes docksal#56 for the MailHog addon using "mail", but it was set t…
1ee3511 
…o "webmail". It appears that this has been for some time been overridden to the subdomain "mail" upstream in docksal/docksal in stacks/services.yml. This was changed in the upstream project from webmail to mail in version 1.7.0.
@frederickjh frederickjh mentioned this issue Mar 6, 2020
Merged
achekulaev pushed a commit that referenced this issue Mar 9, 2020
@frederickjh
Fixes #56 for the adminer addon. (#57)
5f0032f
@achekulaev achekulaev reopened this Mar 9, 2020
@frederickjh
Copy link
Contributor Author

@achekulaev I take it that you checked through the other addons or know that they have switched to use a prefix on the project name as their subdomain name instead of using a subdomain name of the project subdomain name, since you closed this.

@achekulaev
Copy link
Member

@frederickjh well I see the addons you mentioned are covered. I have not checked through other addons. (and frankly have no intention of doing so, this is kind of community-supported repo)

@frederickjh
Copy link
Contributor Author

OK @achekulaev I will take a look and see what I can find.

@frederickjh
Copy link
Contributor Author

The pma addon is the only other addon that I could find using a subdomain of the project subdomain name. I will see what I can do about submitting a pull request for it. The rest of the addons either do not use a web interface or have been changed to use a prefix to the project name.

frederickjh added a commit to frederickjh/addons that referenced this issue Mar 11, 2020
@frederickjh
Fixes docksal#56 for the PHPMyAdmin addon. It now uses the prefix pma…
0c9aed9 
…- on the project name instead of a subdomain of it.
frederickjh added a commit to frederickjh/addons that referenced this issue Mar 11, 2020
@frederickjh
Additional fixes for docksal#56 for the adminer addon.
34d0403
achekulaev pushed a commit that referenced this issue Mar 11, 2020
@frederickjh
Fixes #56 for the PHPMyAdmin addon. It now uses the prefix pma- on th…
c011bd0 
…e project name instead of a subdomain of it. (#60)
achekulaev pushed a commit that referenced this issue Mar 11, 2020
@frederickjh
Feature/56 adminer additional fixes - standarize domain names for add…
2a6b260 
…ons (#61)

* Additional fixes for #56 for the adminer addon.

* File permission changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #56 for the adminer addon. frederickjh/addons
2 participants
@achekulaev @frederickjh